From: Peter Rosin <peda@axentia.se>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Gustaf Lindström" <gl@axentia.se>,
"David Airlie" <airlied@linux.ie>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels
Date: Fri, 28 Oct 2016 14:18:43 +0200 [thread overview]
Message-ID: <464e0d3e-494e-268d-d57d-04c7cedd1e7c@axentia.se> (raw)
In-Reply-To: <20161019123153.GB16158@ulmo.ba.sec>
On 2016-10-19 14:31, Thierry Reding wrote:
> On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote:
>> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
>>> From: Gustaf Lindström <gl@axentia.se>
>>>
>>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>>
>>> The simple-panel driver is used to get support for essential
>>> functionality of the panel.
>>>
>>> Signed-off-by: Gustaf Lindström <gl@axentia.se>
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>>> 1 file changed, 27 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>>> index 85143d1b9b31..58cfe0a7a9d6 100644
>>> --- a/drivers/gpu/drm/panel/panel-simple.c
>>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>>> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>>> },
>>> };
>>>
>>> +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
>>> + .clock = 71100,
>>> + .hdisplay = 1024,
>>> + .hsync_start = 1024 + 168,
>>> + .hsync_end = 1024 + 168 + 64,
>>> + .htotal = 1024 + 168 + 64 + 88,
>>> + .vdisplay = 768,
>>> + .vsync_start = 768 + 37,
>>> + .vsync_end = 768 + 37 + 2,
>>> + .vtotal = 768 + 37 + 2 + 8,
>>> + .vrefresh = 60,
>>> +};
>>> +
>>> +static const struct panel_desc sharp_lq150x1lg11 = {
>>> + .modes = &sharp_lq150x1lg11_mode,
>>> + .num_modes = 1,
>>> + .bpc = 8,
>>> + .size = {
>>> + .width = 304,
>>> + .height = 228,
>>> + },
>>> + .bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>>
>> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
>> RGB565 panels.
>
> Are you actually using the .bpc field in your driver? If yes, can you
> please test if things work correctly if you set it to 6? If it's unused
> I'm leaning towards just applying this with .bpc set to 6 and hope for
> the best (and fix it if somebody finds that it's broken).
>
> So no need to resend, just let me know what you think.
Sorry for the delay, but I just tested .bpc = 6 and it was ok too. It
doesn't seem to matter for us, so do as you like.
Cheers,
Peter
prev parent reply other threads:[~2016-10-28 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 15:29 [PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin
2016-10-04 15:29 ` [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding Peter Rosin
2016-10-09 1:29 ` Rob Herring
2016-10-04 15:29 ` [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin
2016-10-19 12:27 ` Thierry Reding
2016-10-19 12:31 ` Thierry Reding
2016-10-28 12:18 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464e0d3e-494e-268d-d57d-04c7cedd1e7c@axentia.se \
--to=peda@axentia.se \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gl@axentia.se \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).