From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F60C433E1 for ; Tue, 9 Jun 2020 16:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 983D720737 for ; Tue, 9 Jun 2020 16:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qnc9zETf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731249AbgFIQly (ORCPT ); Tue, 9 Jun 2020 12:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730180AbgFIQlv (ORCPT ); Tue, 9 Jun 2020 12:41:51 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE72C05BD1E; Tue, 9 Jun 2020 09:41:50 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id t18so22078769wru.6; Tue, 09 Jun 2020 09:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AZYG0K93PsQJdOxUwBoc+JlrzBQiHlCzR6DIMHy9gzM=; b=Qnc9zETfrjvQCtihO8N+ww82xz2gFstOVQIhtDytjaAswNCjJkOIeNxenav3SKer6u VlZaasnPed6euS+O7aEP2hmu+H+0D3a5p4AaFtTmIeGlu7iALgddtoNyRkyMovUTuvuc XLq8l61ge33GfudUR8C8wyFhghbuozL3uuEkXavOLGGdKDR1ML9zPw3emD6RiCVVTOFH +GpnD32MeXFiSfmBt0ITJWzgbsIYIcZEZl8Dd+IbiiBLAoDv17IxQ5VncBdAxP4QbfbU MwcB6wtaX6S2pvP4df22/0ISfrF47jEmrxFIG+OOXZgfkAEImxIjeRGXAuzqqFuJ8nI8 c3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AZYG0K93PsQJdOxUwBoc+JlrzBQiHlCzR6DIMHy9gzM=; b=mPWXsoYHGShcucGA7dOi2UJURQMllDxqcGYp8eMXjZROY4Y+V3yp84x8NVscRU+Z66 MJowOGUK2FcOGFC71eFzxCcR3lkcb7Y1LOaEYpI5U5kO3CJf00HpsiZboF9O+Ig6NsPu cupvio4j87FXIg0NQTdh6XFfcWTkxSVi38gSKqWrRklcDWZ56e9581ALIXhKE2dtMpt8 Xuo1NoaUzptssK/Hmj6O+elW7br82+6GybOrjOc2KZ7S4eppLLPjACAN6reYKvdzNHmx wCLeJwGX4dlNDSpWuEXke+04ayQ7kEB2wNil9l/1m0xOCQCq1I2G2zQHO7FKhDMm43g/ a2ug== X-Gm-Message-State: AOAM532t2wEs1vEnqpMIK5lOWdkk0j37vIpje4bLtxDROif7zXRhyZiI SE/wChf5NrTn8HwPZqoxVb0= X-Google-Smtp-Source: ABdhPJyGpJCVZw+2xb/iyyGrCWfBAeQZNwZKVIZ4KwrEhZ9D9uA5HLtcYsA8YTZ1D5G9l66zXF2Zlg== X-Received: by 2002:a5d:4d4d:: with SMTP id a13mr5560604wru.252.1591720908896; Tue, 09 Jun 2020 09:41:48 -0700 (PDT) Received: from macbook-pro-alvaro.lan (28.red-83-49-61.dynamicip.rima-tde.net. [83.49.61.28]) by smtp.gmail.com with ESMTPSA id n189sm3488999wmb.43.2020.06.09.09.41.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2020 09:41:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH 3/7] reset: add BCM6345 reset controller driver From: =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= In-Reply-To: <2a621f170574a616bcf047f6725c74552f7abbb1.camel@pengutronix.de> Date: Tue, 9 Jun 2020 18:41:47 +0200 Cc: robh+dt@kernel.org, tsbogend@alpha.franken.de, Florian Fainelli , Jonas Gorski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Content-Transfer-Encoding: quoted-printable Message-Id: <46614E69-578A-4782-9D72-85B2D2F38FB8@gmail.com> References: <20200609134232.4084718-1-noltari@gmail.com> <20200609134232.4084718-4-noltari@gmail.com> <341e8482c6bd06267633160d7358fa8331bef515.camel@pengutronix.de> <729976E9-CAF7-47B6-8783-5FD3D85F9EFD@gmail.com> <2a621f170574a616bcf047f6725c74552f7abbb1.camel@pengutronix.de> To: Philipp Zabel X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Philipp, > El 9 jun 2020, a las 18:32, Philipp Zabel = escribi=C3=B3: >=20 > Hi =C3=81lvaro, >=20 > On Tue, 2020-06-09 at 17:14 +0200, =C3=81lvaro Fern=C3=A1ndez Rojas = wrote: >> Hi Philipp, >>=20 >>> El 9 jun 2020, a las 17:06, Philipp Zabel = escribi=C3=B3: >>>=20 >>> Hi =C3=81lvaro, >>>=20 >>> On Tue, 2020-06-09 at 15:42 +0200, =C3=81lvaro Fern=C3=A1ndez Rojas = wrote: >>>> Add support for resetting blocks through the Linux reset controller >>>> subsystem for BCM63xx SoCs. >>>>=20 >>>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas >>>> --- >>>> drivers/reset/Kconfig | 7 ++ >>>> drivers/reset/Makefile | 1 + >>>> drivers/reset/reset-bcm6345.c | 149 = ++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 157 insertions(+) >>>> create mode 100644 drivers/reset/reset-bcm6345.c >>>>=20 >>>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig >>>> index d9efbfd29646..9f1da978cef6 100644 >>>> --- a/drivers/reset/Kconfig >>>> +++ b/drivers/reset/Kconfig >>>> @@ -41,6 +41,13 @@ config RESET_BERLIN >>>> help >>>> This enables the reset controller driver for Marvell Berlin = SoCs. >>>>=20 >>>> +config RESET_BCM6345 >>>> + bool "BCM6345 Reset Controller" >>>> + depends on BMIPS_GENERIC || COMPILE_TEST >>>> + default BMIPS_GENERIC >>>> + help >>>> + This enables the reset controller driver for BCM6345 SoCs. >>>> + >>>> config RESET_BRCMSTB >>>> tristate "Broadcom STB reset controller" >>>> depends on ARCH_BRCMSTB || COMPILE_TEST >>>> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile >>>> index 249ed357c997..e642aae42f0f 100644 >>>> --- a/drivers/reset/Makefile >>>> +++ b/drivers/reset/Makefile >>>> @@ -6,6 +6,7 @@ obj-$(CONFIG_ARCH_TEGRA) +=3D tegra/ >>>> obj-$(CONFIG_RESET_A10SR) +=3D reset-a10sr.o >>>> obj-$(CONFIG_RESET_ATH79) +=3D reset-ath79.o >>>> obj-$(CONFIG_RESET_AXS10X) +=3D reset-axs10x.o >>>> +obj-$(CONFIG_RESET_BCM6345) +=3D reset-bcm6345.o >>>> obj-$(CONFIG_RESET_BERLIN) +=3D reset-berlin.o >>>> obj-$(CONFIG_RESET_BRCMSTB) +=3D reset-brcmstb.o >>>> obj-$(CONFIG_RESET_BRCMSTB_RESCAL) +=3D reset-brcmstb-rescal.o >>>> diff --git a/drivers/reset/reset-bcm6345.c = b/drivers/reset/reset-bcm6345.c >>>> new file mode 100644 >>>> index 000000000000..088b7fdb896b >>>> --- /dev/null >>>> +++ b/drivers/reset/reset-bcm6345.c >>>> @@ -0,0 +1,149 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-or-later >>>> +/* >>>> + * BCM6345 Reset Controller Driver >>>> + * >>>> + * Copyright (C) 2020 =C3=81lvaro Fern=C3=A1ndez Rojas = >>>> + */ >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#define BCM6345_RESET_NUM 32 >>>> +#define BCM6345_RESET_SLEEP_MIN_US 10000 >>>> +#define BCM6345_RESET_SLEEP_MAX_US 20000 >>>> + >>>> +struct bcm6345_reset { >>>> + struct reset_controller_dev rcdev; >>>> + void __iomem *base; >>>> + spinlock_t lock; >>>> +}; >>>> + >>>> +static int bcm6345_reset_update(struct bcm6345_reset = *bcm6345_reset, >>>> + unsigned long id, bool assert) >>>> +{ >>>> + uint32_t val; >>>> + >>>> + val =3D __raw_readl(bcm6345_reset->base); >>>> + if (assert) >>>> + val &=3D ~BIT(id); >>>> + else >>>> + val |=3D BIT(id); >>>> + __raw_writel(val, bcm6345_reset->base); >>>> + >>>> + return 0; >>>> +} >>>> + >>>> +static int bcm6345_reset_assert(struct reset_controller_dev = *rcdev, >>>> + unsigned long id) >>>> +{ >>>> + struct bcm6345_reset *bcm6345_reset =3D >>>> + container_of(rcdev, struct bcm6345_reset, rcdev); >>>> + unsigned long flags; >>>> + >>>> + spin_lock_irqsave(&bcm6345_reset->lock, flags); >>>> + bcm6345_reset_update(bcm6345_reset, id, true); >>>> + spin_unlock_irqrestore(&bcm6345_reset->lock, flags); >>>> + >>>> + return 0; >>>> +} >>>> + >>>> +static int bcm6345_reset_deassert(struct reset_controller_dev = *rcdev, >>>> + unsigned long id) >>>> +{ >>>> + struct bcm6345_reset *bcm6345_reset =3D >>>> + container_of(rcdev, struct bcm6345_reset, rcdev); >>>> + unsigned long flags; >>>> + >>>> + spin_lock_irqsave(&bcm6345_reset->lock, flags); >>>> + bcm6345_reset_update(bcm6345_reset, id, false); >>>> + spin_unlock_irqrestore(&bcm6345_reset->lock, flags); >>>> + >>>> + return 0; >>>> +} >>>> + >>>> +static int bcm6345_reset_reset(struct reset_controller_dev *rcdev, >>>> + unsigned long id) >>>> +{ >>>> + struct bcm6345_reset *bcm6345_reset =3D >>>> + container_of(rcdev, struct bcm6345_reset, rcdev); >>>> + unsigned long flags; >>>> + >>>> + spin_lock_irqsave(&bcm6345_reset->lock, flags); >>>> + usleep_range(BCM6345_RESET_SLEEP_MIN_US, >>>> + BCM6345_RESET_SLEEP_MAX_US); >>>=20 >>> What is the purpose of sleeping before reset assertion? >>=20 >> None, I must have introduced that for testing something and then I = forgot to remove it. Sorry for that... >>=20 >>> If you can do without this, with I think this driver could be made = to >>> use reset-simple. >>=20 >> Yes, but only if I can add reset support with a configurable sleep = range to reset-simple. Is this possible? >=20 > I should have mentioned, support for this is on the reset/next branch: >=20 > git://git.pengutronix.de/pza/linux.git reset/next Yes, but reset_us was only added to reset_simple_data, so there=E2=80=99s = no way to fill that value from reset_simple_devdata or device tree, = right? >=20 > regards > Philipp Regards, =C3=81lvaro.