From: Max Staudt <max@enpas.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Date: Thu, 15 Aug 2019 14:10:56 +0200 [thread overview]
Message-ID: <4661d2f3-13e1-ff62-22e1-e4391ccc38b2@enpas.org> (raw)
In-Reply-To: <20190815120430.GB1916@kunai>
On 08/15/2019 02:04 PM, Wolfram Sang wrote:
>> When the PCF8584 is addressed as slave, this register
>> must be loaded with the 7-bit I 2 C-bus address to which the
>> PCF8584 is to respond. During initialization, the own
>> address register S0' must be written to, regardless
>> whether it is later used.
>
> I see. It must be written a non-zero value to leave the monitor mode.
> But this really needs no callback, we can hardcode any non-zero value.
> If slave support is (ever) to be implemented, the own address will come
> from the I2C core.
The callback, just like getclock(), is from the existing i2c-algo-pcf, which I don't want to touch right now. So I'm afraid it has to stay, even if it returns a fixed number.
Touching or forking i2c-algo-pcf will be necessary in order to implement IRQ support, if I ever get around to it. I've wasted too much time on debugging IRQ support, and would rather do it another time, if ever ;)
I've left a comment block at the start of i2c-icy.c for anyone interested in the gory details.
If this is okay with you, I'll send another round of patches. :)
Thanks!
Max
next prev parent reply other threads:[~2019-08-15 12:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 23:52 [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-12 23:52 ` [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-13 7:03 ` Geert Uytterhoeven
2019-08-13 9:49 ` Max Staudt
2019-08-14 19:52 ` Wolfram Sang
2019-08-12 23:52 ` [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support Max Staudt
2019-08-13 6:59 ` Geert Uytterhoeven
2019-08-13 8:02 ` Guenter Roeck
2019-08-13 8:27 ` Geert Uytterhoeven
2019-08-13 13:27 ` Guenter Roeck
2019-08-13 13:32 ` Geert Uytterhoeven
2019-08-13 10:10 ` Max Staudt
2019-08-13 13:24 ` Guenter Roeck
2019-08-13 13:31 ` Max
2019-08-14 18:11 ` Max Staudt
2019-08-12 23:52 ` [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990 Max Staudt
2019-08-13 7:04 ` Geert Uytterhoeven
2019-08-13 7:08 ` [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Geert Uytterhoeven
2019-08-13 9:50 ` Max Staudt
2019-08-14 19:47 ` Wolfram Sang
2019-08-14 22:33 ` Max Staudt
2019-08-15 7:12 ` Wolfram Sang
2019-08-15 10:00 ` Max Staudt
2019-08-15 11:48 ` Wolfram Sang
2019-08-15 11:52 ` Max
2019-08-15 12:04 ` Wolfram Sang
2019-08-15 12:10 ` Max Staudt [this message]
2019-08-15 12:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4661d2f3-13e1-ff62-22e1-e4391ccc38b2@enpas.org \
--to=max@enpas.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).