From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdCAAxz (ORCPT ); Tue, 28 Feb 2017 19:53:55 -0500 Received: from mx1.yrkesakademin.fi ([85.134.45.194]:58031 "EHLO mx1.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbdCAAxw (ORCPT ); Tue, 28 Feb 2017 19:53:52 -0500 Subject: Re: [PATCH 1/2] Correct function definition for C++ To: Joakim Tjernlund References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> <20170222071022.GA9186@kroah.com> <1487749844.5760.17.camel@infinera.com> CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" From: Thomas Backlund Message-ID: <46622022-68e2-35eb-e6d6-55f7a62c6f94@mageia.org> Date: Wed, 1 Mar 2017 01:15:06 +0200 MIME-Version: 1.0 In-Reply-To: <1487749844.5760.17.camel@infinera.com> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 7bit X-WatchGuard-Spam-ID: str=0001.0A0C0203.58B61BA0.0085,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-WatchGuard-Spam-Score: 0, clean; 0, virus threat unknown X-WatchGuard-Mail-Client-IP: 85.134.45.194 X-WatchGuard-Mail-From: tmb@mageia.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 22.02.2017 kl. 09:50, skrev Joakim Tjernlund: > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: >> On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: >>> C++ does does not like the extra extern before asmlinkage, remove it. >>> >>> Signed-off-by: Joakim Tjernlund >>> --- >>> include/linux/printk.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/printk.h b/include/linux/printk.h >>> index 3472cc6..be823f5 100644 >>> --- a/include/linux/printk.h >>> +++ b/include/linux/printk.h >> >> >> Why are you building this file with a C++ compiler? > > virtualbox uses C++ and includes various kernel headers and the build > fails, virtualbox guest additions has not build for quite some time now and > this is one of the problems. You need this fix for virtualbox: https://www.virtualbox.org/changeset/65874/vbox/trunk/configure -- Thomas