From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762594AbcINNwC (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 09:52:02 -0400
Received: from mout.kundenserver.de ([217.72.192.74]:62773 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1762492AbcINNv6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 09:51:58 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: phy: add USB_SUPPORT dependency
Date: Wed, 14 Sep 2016 15:51:41 +0200
Message-ID: <4663023.yR0rtq6Tke@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <57D1699C.4080406@ti.com>
References: <20160906125516.1551565-1-arnd@arndb.de> <20915b65-8be3-cee4-cac1-eab512ab74f5@redhat.com> <57D1699C.4080406@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:TYdLdrgoH4EwOtppbWEbbdUdKoRIeKoFpPkKE7HAPEvyuN3MXAv
 uzCCYaG0ZcPzA0d0Hc9JZdT4ntbdX3kbQWvOTLXG1gjUy6PEK++H1expj4MNcw2a3TfSeXf
 dyS+lzGeIU/v6FRo0hiFx0MUWfuWI2WVyaRm4wI+0kYyQR06otxn89mLWMoADseJVVFWS3V
 EqwBHTsmOV5RFp4c8Um+A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:fIwIk7HT7C8=:nWhTnmO9oFkpL3VL0H3+uZ
 acdiFD9j1P075FLemkAKlgxaAFrVOVUlX1ivuCgtyTZsEFnoo/Pr5bOL0UM8YBfWSU0+NmZoy
 30LvQE1tsY0sqp8BeNS+wqiEtDqYOQgemx9BGsQ+ggHKG2HxA/B0PRXXskYo+vu/r134wyFmt
 /1JpPWKI2QyTkGxXbG0UG1peMbDd/ypWJf179M9qfy5wORhmx0oXUNwwRGcLSS818l8vjn3WB
 PETdu6sfQyHESRq4VwTJDEErtEDNEu2SpX9JT708/i+g0IVpenZV+4ZRsKSHzIEruYnB9o6/5
 qZshlV31d8Nb1nVe1ri5V+uk+dixZ4E8K5+L7jTKCSXr1kdpqrMv/2Mj+v7zjbv2tWKpCUzQD
 TyuR80xo7qMs9x1OXKLVC0eVzLAjTrtEYsyQBK/YFGabGP1YLjZDXW12SmDDmBhW4VhtWWvxH
 vkfMLJjc9eLybpCXSaBojeBOOiBPvlO1KQ8YHhpYOMs7ueUJMbPxB4EqjQTVPk+41L4m4zM2E
 UnO/st554Tp54EMyLzhpPVj4HhSYEf79kyKu5XTEEADH+wAaWFDMog6Aj2BrOre0kVxZV2wUb
 iUmJfk06Yg2r98ihrdUv+Qm3rKPBYB6StLDBOH5ddU78GL30q1dWsTiwvOPUvyzBQ2Mn+dwZB
 tiRJiRIwNnUrTC6W86epioPCmvLo32ohq7sSWB0NH9Scx4S96xS2oD3/3NHbWsBXM9SZPh5Ij
 L/OAOERO6UHe+Neu
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, September 8, 2016 7:07:32 PM CEST Kishon Vijay Abraham I wrote:
> 
> On Wednesday 07 September 2016 03:01 PM, Hans de Goede wrote:
> > Hi,
> > 
> > On 06-09-16 14:54, Arnd Bergmann wrote:
> >> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
> >> USB core layer, and it fails to build when that is not provided:
> >>
> >> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
> >> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to
> >> `of_usb_get_dr_mode_by_phy'
> >>
> >> We already have a couple of other PHY drivers with a dependency
> >> on USB_SUPPORT, so that seems to be the easiest fix here.
> >>
> >> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
> >> to also check for CONFIG_USB_SUPPORT.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
> > 
> > Good catch, patch LGTM:
> > 
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> merged, thanks.
> 

There is one more that came up today, with the meson usb2 phy driver.

I've now implemented the "alternative" I mentioned above, which should
avoid introducing other instances of this bug in the future.

Sorry for all the back-and-forth here,

	Arnd