From: David Greaves <david@dgreaves.com>
To: David Chinner <dgc@sgi.com>
Cc: David Robinson <zxvdr.au@gmail.com>,
LVM general discussion and development <linux-lvm@redhat.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, linux-pm <linux-pm@lists.osdl.org>,
LinuxRaid <linux-raid@vger.kernel.org>
Subject: Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume
Date: Mon, 18 Jun 2007 20:14:06 +0100 [thread overview]
Message-ID: <4676D97E.4000403@dgreaves.com> (raw)
In-Reply-To: <20070618145007.GE85884050@sgi.com>
OK, just an quick ack
When I resumed tonight (having done a freeze/thaw over the suspend) some libata
errors threw up during the resume and there was an eventual hard hang. Maybe I
spoke to soon?
I'm going to have to do some more testing...
David Chinner wrote:
> On Mon, Jun 18, 2007 at 08:49:34AM +0100, David Greaves wrote:
>> David Greaves wrote:
>> So doing:
>> xfs_freeze -f /scratch
>> sync
>> echo platform > /sys/power/disk
>> echo disk > /sys/power/state
>> # resume
>> xfs_freeze -u /scratch
>>
>> Works (for now - more usage testing tonight)
>
> Verrry interesting.
Good :)
> What you were seeing was an XFS shutdown occurring because the free space
> btree was corrupted. IOWs, the process of suspend/resume has resulted
> in either bad data being written to disk, the correct data not being
> written to disk or the cached block being corrupted in memory.
That's the kind of thing I was suspecting, yes.
> If you run xfs_check on the filesystem after it has shut down after a resume,
> can you tell us if it reports on-disk corruption? Note: do not run xfs_repair
> to check this - it does not check the free space btrees; instead it simply
> rebuilds them from scratch. If xfs_check reports an error, then run xfs_repair
> to fix it up.
OK, I can try this tonight...
> FWIW, I'm on record stating that "sync" is not sufficient to quiesce an XFS
> filesystem for a suspend/resume to work safely and have argued that the only
> safe thing to do is freeze the filesystem before suspend and thaw it after
> resume. This is why I originally asked you to test that with the other problem
> that you reported. Up until this point in time, there's been no evidence to
> prove either side of the argument......
>
> Cheers,
>
> Dave.
next prev parent reply other threads:[~2007-06-18 19:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-16 19:56 2.6.22-rc4 XFS fails after hibernate/resume David Greaves
2007-06-16 22:29 ` [linux-lvm] " David Robinson
2007-06-17 11:38 ` David Greaves
2007-06-18 7:49 ` David Greaves
2007-06-18 14:50 ` David Chinner
2007-06-18 19:14 ` David Greaves [this message]
2007-06-19 9:24 ` [linux-lvm] 2.6.22-rc5 " David Greaves
2007-06-19 9:44 ` Tejun Heo
2007-06-19 14:13 ` David Greaves
2007-06-20 8:03 ` Tejun Heo
2007-06-21 18:06 ` David Greaves
2007-06-29 8:20 ` David Greaves
2007-07-02 10:56 ` Tejun Heo
2007-07-02 14:08 ` Rafael J. Wysocki
2007-07-02 14:32 ` David Greaves
2007-07-02 15:12 ` Rafael J. Wysocki
2007-07-02 16:36 ` David Greaves
2007-07-02 20:15 ` Rafael J. Wysocki
2007-06-19 11:21 ` Rafael J. Wysocki
2007-06-19 15:31 ` David Greaves
2007-06-20 0:18 ` David Chinner
2007-06-27 20:49 ` [linux-lvm] 2.6.22-rc4 " Pavel Machek
2007-06-28 15:27 ` Rafael J. Wysocki
2007-06-28 22:00 ` [linux-pm] " Pavel Machek
2007-06-28 22:16 ` Rafael J. Wysocki
2007-06-29 5:00 ` David Chinner
2007-06-29 7:40 ` David Greaves
2007-06-29 7:43 ` David Chinner
2007-06-29 7:54 ` David Greaves
2007-06-29 13:18 ` Rafael J. Wysocki
2007-06-29 13:30 ` David Greaves
2007-06-29 4:55 ` David Chinner
2007-06-16 22:47 ` Rafael J. Wysocki
2007-06-17 11:37 ` David Greaves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4676D97E.4000403@dgreaves.com \
--to=david@dgreaves.com \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm@redhat.com \
--cc=linux-pm@lists.osdl.org \
--cc=linux-raid@vger.kernel.org \
--cc=xfs@oss.sgi.com \
--cc=zxvdr.au@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).