From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754386AbcBZN6r (ORCPT ); Fri, 26 Feb 2016 08:58:47 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:56723 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbcBZN6p (ORCPT ); Fri, 26 Feb 2016 08:58:45 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Justin Chen , linux-kernel@vger.kernel.org, f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com, Justin Chen , bcm-kernel-feedback-list@broadcom.com, gregory.0xf0@gmail.com, computersforpeace@gmail.com Subject: Re: [PATCH] bsp: add SoC device to brcmstb Date: Fri, 26 Feb 2016 14:58:15 +0100 Message-ID: <4679582.DyKPu0pJrQ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1456445947-9079-1-git-send-email-justinpopo6@gmail.com> References: <1456445947-9079-1-git-send-email-justinpopo6@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:2RQ1C4mcBTIxP7MOjX+yiMwlkmf78D4gnVn7lLFZQf3x/g5Mypl iJqSVIjJkHmt8jOJIaR8U5XLgDZ7lAa1gz1JwHc6QORugLj76OrCRTgn089C+r7JG2u6496 l/6uXJSyxMS1mUFlgf3R20qNh61KPWRvZbZLN0RxHyq5vgZwhYXJ9HB3K6GofSNlN7K1pKP Ne6aQ0GgVCfdp9aSVm4hw== X-UI-Out-Filterresults: notjunk:1;V01:K0:6GU+TVES/fs=:l2rJbr7s/AqlW3SomMqcea sD5ugcbeESq1iIloXRpCGkuc5w173hrWlCKlBPSB3qM/JTiIAf+nITqin/UulPKoxUrEA/Pa0 uEROtSut1aCYA02jFtMmkBpuaE9bp9Rc+78JabDPXz4i7W4K40HdDGROKRrXxeZA+uVUEKZ/x 1KDdKZ2LcHIB9Ltcj5U+vB5/auDSDXm1JL0DSWEOkRpZOos5VG7wQBPXGLuZcWTu/lYFKbYiv ujjf5z7OpMCRDZG9OpXkQDYKoChaIonps5Vz5KGXbJNb7CX2tWSBnE0cXWCK9XOjsfiQv5vZM NtEW73HEz62OtJRrCHonQW2de6MwGLuj5VclM7mymCVZUTKxmcb5j390Q51rPUX0AgBQxOf5g yZC7dm3UcXGzKH2ahUqQweIt1B3QJcBiCVXTlR9VguJgA2DyxQdgkmsiDkrezN/b6Cp69tMVn 4iGX4d8tQP6v5q92es1UsDKaLAByenAzCyHw87i5FNNSGDwhcZt6/kuztZJHLeZkH+w7HzwF+ 9T2ReGAAH5bwtOMJeWMkDYROD5LnJwlYOiwaH2YPuvTFY5L7S4MtndVGNeCL0CixcJgn8c8oB cRMthE35VdqROjFrfvIDqyy+Kyox279p+4ttIIFFr/wO0Q4GcP6+f7zxgCdoBdf887PfbPwsK vqnOSS+W+zaBK1iMTgXqRErpula7V9vrHxLIrnB4hRyIcgcGPThNNZAjqpQf5k+wjsv/j6Oy4 FsxU6I+K+n41rcab Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 February 2016 16:19:07 Justin Chen wrote: > */ > void brcmstb_biuctrl_init(void); > > +/* > + * Helper functions for getting family or product id from the > + * SoC driver. > + */ > +u32 brcmstb_get_family_id(void); > +u32 brcmstb_get_product_id(void); > + > #endif /* __BRCMSTB_SOC_H */ > -- Please remove the declarations from the header file and make the variable local to this file, to make sure no other driver accidentally accesses them. Arnd