From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Paul Mackerras <paulus@samba.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Arch <linux-arch@vger.kernel.org>,
Richard Henderson <rth@twiddle.net>, Ian Molton <spyro@f2s.com>,
Russell King <rmk@arm.linux.org.uk>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Aubrey Li <aubrey.li@analog.com>,
Mikael Starvik <starvik@axis.com>,
David Howells <dhowells@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Andi Kleen <ak@suse.de>, Tony Luck <tony.luck@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ralf Baechle <ralf@linux-mips.org>,
Matthew Wilcox <matthew@wil.cx>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Miles Bader <uclinux-v850@lsi.nec.co.jp>,
Chris Zankel <chris@zankel.net>
Subject: Re: [PATCH] cross-architecture ELF clean up
Date: Fri, 29 Jun 2007 01:31:18 -0400 [thread overview]
Message-ID: <46849926.8050702@goop.org> (raw)
In-Reply-To: <18052.36612.846937.794756@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
>> ===================================================================
>> --- a/arch/powerpc/platforms/cell/io-workarounds.c
>> +++ b/arch/powerpc/platforms/cell/io-workarounds.c
>> @@ -9,6 +9,7 @@
>> #undef DEBUG
>>
>> #include <linux/kernel.h>
>> +#include <linux/sched.h>
>>
>
> Why is this needed? You've added #include <linux/sched.h> to 7 files
> without explanation - and I can't see that you have removed a
> corresponding #include from any header, have you?
>
asm-powerpc/elf.h included sched.h, and it in turn was being included by
something else. With the cleanups in this patch, asm-powerpc/elf.h is
no longer being included, so io-workarounds.c needs kernel/sched.h for a
declaration of init_mm.
Similarly with the others; they all failed to compile without linux/sched.h.
J
prev parent reply other threads:[~2007-06-29 5:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070620230854.246399397@goop.org>
2007-06-20 23:08 ` [PATCH] cross-architecture ELF clean up Jeremy Fitzhardinge
2007-06-21 8:20 ` ian
2007-06-21 15:06 ` Jeremy Fitzhardinge
2007-06-21 16:49 ` Chris Zankel
2007-06-21 18:31 ` Jeremy Fitzhardinge
2007-06-25 9:02 ` David Woodhouse
2007-06-25 12:43 ` Jeremy Fitzhardinge
2007-06-25 13:40 ` Roman Zippel
2007-06-25 13:56 ` Clemens Koller
2007-06-25 14:06 ` Roman Zippel
2007-06-25 13:37 ` Roman Zippel
2007-06-26 19:29 ` Jeremy Fitzhardinge
2007-06-27 23:25 ` Roman Zippel
2007-06-28 15:45 ` Jeremy Fitzhardinge
2007-06-28 21:48 ` Roman Zippel
2007-06-29 14:53 ` Jeremy Fitzhardinge
2007-06-29 18:12 ` Sam Ravnborg
2007-07-01 16:23 ` Jeremy Fitzhardinge
2007-06-25 15:18 ` Roman Zippel
2007-06-26 19:28 ` Jeremy Fitzhardinge
2007-06-29 4:13 ` Paul Mackerras
2007-06-29 5:31 ` Jeremy Fitzhardinge
2007-06-29 4:48 ` Paul Mackerras
2007-06-29 5:31 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46849926.8050702@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=aubrey.li@analog.com \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=hskinnemoen@atmel.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rmk@arm.linux.org.uk \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=spyro@f2s.com \
--cc=starvik@axis.com \
--cc=tony.luck@intel.com \
--cc=uclinux-v850@lsi.nec.co.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).