From: Luca Weiss <luca@z3ntu.xyz>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/15] arm64: dts: qcom: Add MSM8953 device tree
Date: Sat, 19 Feb 2022 12:50:52 +0100 [thread overview]
Message-ID: <4689218.GXAFRqVoOG@g550jk> (raw)
In-Reply-To: <YgvXdFZfWEzHF2Oy@yoga>
Hi Bjorn,
On Dienstag, 15. Februar 2022 17:40:20 CET Bjorn Andersson wrote:
> On Wed 12 Jan 13:40 CST 2022, Luca Weiss wrote:
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >
> > Add a base DT for MSM8953 SoC.
> >
> > Co-developed-by: Luca Weiss <luca@z3ntu.xyz>
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> >
> > arch/arm64/boot/dts/qcom/msm8953.dtsi | 1337 +++++++++++++++++++++++++
> > 1 file changed, 1337 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8953.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> > b/arch/arm64/boot/dts/qcom/msm8953.dtsi new file mode 100644
> > index 000000000000..59918b527750
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> > @@ -0,0 +1,1337 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */
> > +
> > +#include <dt-bindings/clock/qcom,gcc-msm8953.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/qcom-rpmpd.h>
> > +#include <dt-bindings/thermal/thermal.h>
> > +
> > +/ {
> > + interrupt-parent = <&intc>;
> > +
> > + #address-cells = <2>;
> > + #size-cells = <2>;
>
> Why do you have address/size-cells of 2, and then limit them to 1 in
> /soc?
Quite a few arm64 qcom dtsi files use #address-cells & #size-cells = <1> which
also makes reg properties quite more readable - and we don't need the 64 bits
on 8953.
>
> > +
> > + aliases {
> > + i2c1 = &i2c_1;
> > + i2c2 = &i2c_2;
> > + i2c3 = &i2c_3;
> > + i2c4 = &i2c_4;
> > + i2c5 = &i2c_5;
> > + i2c6 = &i2c_6;
> > + i2c7 = &i2c_7;
> > + i2c8 = &i2c_8;
>
> It was expressed a while back that you should specify alias only for the
> things that you have enabled in your .dts.
Sure, I'll remove it.
>
> > + };
>
> [..]
>
> > + tcsr_mutex: hwlock@1905000 {
> > + compatible = "qcom,tcsr-mutex";
> > + reg = <0x1905000 0x20000>;
> > + #hwlock-cells = <1>;
> > + };
> > +
> > + tcsr: syscon@1937000 {
> > + compatible = "qcom,tcsr-msm8953", "syscon";
> > + reg = <0x1937000 0x30000>;
> > + };
> > +
> > + tcsr_phy_clk_scheme_sel: syscon@193f044 {
>
> I don't fancy exposing a single word from the middle of &tcsr using a
> syscon. The tcsr node should express the TCSR region and if we need to
> reference bits of information within that we should do that in some
> structured way.
>
> Wouldn't nvmem be a good candidate for this?
The qusb2 bindings expect the reference like this as far as I can tell,
qphy->tcsr = syscon_regmap_lookup_by_phandle(dev->of_node,
"qcom,tcsr-syscon");
So I don't think we can change this without changing the driver as well?
Regards
Luca
>
> > + compatible = "syscon";
> > + reg = <0x193f044 0x4>;
> > + };
> > +
>
> Regards,
> Bjorn
next prev parent reply other threads:[~2022-02-19 11:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 19:40 [PATCH 00/15] Initial MSM8953 & Fairphone 3 support Luca Weiss
2022-01-12 19:40 ` [PATCH 01/15] dt-bindings: phy: qcom,qusb2: Document msm8953 compatible Luca Weiss
2022-01-27 5:30 ` Vinod Koul
2022-01-12 19:40 ` [PATCH 02/15] phy: qcom-qusb2: Add compatible for MSM8953 Luca Weiss
2022-01-27 5:30 ` Vinod Koul
2022-01-12 19:40 ` [PATCH 03/15] dt-bindings: mfd: qcom,tcsr: Document msm8953 compatible Luca Weiss
2022-02-09 2:12 ` Rob Herring
2022-02-15 12:58 ` Lee Jones
2022-01-12 19:40 ` [PATCH 04/15] mfd: qcom-spmi-pmic: Add pm8953 compatible Luca Weiss
2022-02-09 2:12 ` Rob Herring
2022-02-15 12:59 ` Lee Jones
2022-01-12 19:40 ` [PATCH 05/15] dt-bindings: mmc: sdhci-msm: Add msm8953 compatible Luca Weiss
2022-01-24 14:41 ` Ulf Hansson
2022-01-12 19:40 ` [PATCH 06/15] dt-bindings: thermal: tsens: " Luca Weiss
2022-01-20 10:58 ` Amit Kucheria
2022-02-09 2:13 ` Rob Herring
2022-01-12 19:40 ` [PATCH 07/15] dt-bindings: usb: qcom,dwc3: " Luca Weiss
2022-02-09 2:13 ` Rob Herring
2022-01-12 19:40 ` [PATCH 08/15] dt-bindings: pinctrl: qcom: msm8953: allow gpio-reserved-ranges Luca Weiss
2022-02-09 2:14 ` Rob Herring
2022-02-11 0:06 ` Linus Walleij
2022-01-12 19:40 ` [PATCH 09/15] rpmsg: smd: Drop unnecessary condition for channel creation Luca Weiss
2022-01-12 21:39 ` Stephan Gerhold
2022-01-16 16:08 ` Luca Weiss
2022-01-16 16:30 ` Stephan Gerhold
2022-01-31 22:32 ` Bjorn Andersson
2022-02-06 20:17 ` Luca Weiss
2022-02-13 20:51 ` Luca Weiss
2022-02-15 15:34 ` Bjorn Andersson
2022-01-31 22:34 ` Bjorn Andersson
2022-01-12 19:40 ` [PATCH 10/15] arm64: dts: qcom: Add MSM8953 device tree Luca Weiss
2022-02-15 16:40 ` Bjorn Andersson
2022-02-19 11:50 ` Luca Weiss [this message]
2022-01-12 19:41 ` [PATCH 11/15] arm64: dts: qcom: Add PM8953 PMIC Luca Weiss
2022-02-07 21:08 ` rayyan
2022-02-09 16:19 ` Rayyan Ansari
2022-01-12 19:41 ` [PATCH 12/15] arm64: dts: qcom: Add SDM632 device tree Luca Weiss
2022-02-15 16:31 ` Bjorn Andersson
2022-01-12 19:41 ` [PATCH 13/15] arm64: dts: qcom: Add MSM8953+PM8953 " Luca Weiss
2022-01-31 22:39 ` Bjorn Andersson
2022-02-13 20:25 ` Luca Weiss
2022-02-14 4:59 ` Bjorn Andersson
2022-01-12 19:41 ` [PATCH 14/15] dt-bindings: arm: qcom: Document sdm632 and fairphone,fp3 board Luca Weiss
2022-02-09 2:14 ` Rob Herring
2022-01-12 19:41 ` [PATCH 15/15] arm64: dts: qcom: sdm632: Add device tree for Fairphone 3 Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4689218.GXAFRqVoOG@g550jk \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.lypak@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).