From: Heiko Stuebner <heiko@sntech.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Thierry Reding <thierry.reding@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.
Date: Mon, 19 Feb 2018 10:56:04 +0100 [thread overview]
Message-ID: <4692672.MjQUXlf6O3@phil> (raw)
In-Reply-To: <20180219092247.estv4d2v6cbopx6z@dell>
Hi Lee,
Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones:
> On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote:
>
> > Hardware needs a delay between setting an initial (non-zero) PWM and
> > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies
> > this delay in milli seconds. Hardware also needs a delay between disabing
> > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms
> > is this delay in milli seconds.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > ---
> > Based on the original Huang Lin <hl@rock-chips.com> work.
> >
> > Changes since v4:
> > - Rebase on top of mainline.
> > Changes since v3:
> > - Replace us for ms.
> > - Add Acked-by: Pavel Machek <pavel@ucw.cz>
> > Changes since v2:
> > - Use separate properties (Rob Herring)
> > Changes since v1:
> > - As suggested by Daniel Thompson
> > - Do not assume power-on delay and power-off delay will be the same
> >
> > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Looks like this still needs an Ack.
>
> Also, you didn't supply a 0th (cover-letter) patch, so I have no idea
> of patch history or your future intentions.
>
> Are there build-time dependencies between them or can each patch be
> merged via their respective trees without the fear of merge/build
> failure?
When looking at the patches, there do not seem to be any build-time
dependencies between the patch 1-3 (backlight) and 4+5 devicetree,
so after Rob hopefully has time to look at the binding change, I'd suspect
you take the code changes and I'll take the dts changes.
Heiko
next prev parent reply other threads:[~2018-02-19 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:40 [RESEND PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Enric Balletbo i Serra
2018-02-16 17:40 ` [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties Enric Balletbo i Serra
2018-02-19 9:22 ` Lee Jones
2018-02-19 9:56 ` Heiko Stuebner [this message]
2018-02-19 10:39 ` Lee Jones
2018-02-19 11:11 ` Daniel Thompson
2018-03-09 10:14 ` Enric Balletbo Serra
2018-03-12 9:10 ` Lee Jones
2018-03-19 16:58 ` Thierry Reding
2018-02-16 17:40 ` [RESEND PATCH v5 3/5] pwm-backlight: add support for PWM delays proprieties Enric Balletbo i Serra
2018-03-19 16:59 ` Thierry Reding
2018-02-16 17:40 ` [RESEND PATCH v5 4/5] ARM: dts: rockchip: set PWM delay backlight settings for Veyron Enric Balletbo i Serra
2018-02-16 17:40 ` [RESEND PATCH v5 5/5] ARM: dts: rockchip: set PWM delay backlight settings for Minnie Enric Balletbo i Serra
2018-03-19 16:58 ` [RESEND PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle Thierry Reding
2018-03-19 18:28 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4692672.MjQUXlf6O3@phil \
--to=heiko@sntech.de \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).