LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Jan Kotas <jank@cadence.com>
To: Rob Herring <robh@kernel.org>
Cc: Jan Kotas <jank@cadence.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: Add bindings for Cadence RTC
Date: Thu, 17 Jan 2019 10:46:50 +0000
Message-ID: <46BA7224-B229-4594-B039-8801A806657E@global.cadence.com> (raw)
In-Reply-To: <20190116210806.GA21535@bogus>


> On 16 Jan 2019, at 22:08, Rob Herring <robh@kernel.org> wrote:
> 
> 
> On Fri, Jan 11, 2019 at 03:14:00PM +0000, Jan Kotas wrote:
>> This patch adds a DT binding documentation for
>> Cadence RTC controller.
>> +Required properties:
>> +- compatible: Should be "cdns,rtc-r109v3"
>> +- reg: Specifies base physical address and size of the register area.
>> +- interrupts: A single interrupt specifier.
>> +- clocks: Must contain two entries:
>> +	- pclk: APB registers clock
>> +	- ref_clk: reference 1Hz of 100Hz clock, depending on IP configuration
> 
> 1Hz OR 100Hz?

Hi,

The IP has a configuration parameter at build time,
which selects the reference clock frequency.

It cannot be changed later, and there’s no register which
tells the software which option was selected.

In this version of the patch, both values are accepted.
If it makes sense I can add a bool property, like
refclock-100hz, which can be used to check the clock frequency.

Regards,
Jan


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 15:13 [PATCH v2 0/2] rtc: Add a driver " Jan Kotas
2019-01-11 15:14 ` [PATCH v2 1/2] dt-bindings: rtc: Add bindings " Jan Kotas
2019-01-16 21:08   ` Rob Herring
2019-01-17 10:46     ` Jan Kotas [this message]
2019-01-17 12:08       ` Alexandre Belloni
2019-01-11 15:14 ` [PATCH v2 2/2] rtc: Add Cadence RTC driver Jan Kotas

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BA7224-B229-4594-B039-8801A806657E@global.cadence.com \
    --to=jank@cadence.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox