linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandru Ardelean <aardelean@deviqon.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jic23@kernel.org, Jonathan.Cameron@huawei.com,
	alexandru.tachici@analog.com, linux@deviqon.com
Subject: Re: [PATCH v3 04/12] iio: adc: ad7192: handle zero Avdd regulator value
Date: Thu, 13 May 2021 09:41:10 +0200	[thread overview]
Message-ID: <46a03414-0ead-46a1-f0fe-20f1c22a70b5@metafoo.de> (raw)
In-Reply-To: <20210512174914.10549-5-aardelean@deviqon.com>

On 5/12/21 7:49 PM, Alexandru Ardelean wrote:
> This change fixes a corner-case, where for a zero regulator value, the
> driver would exit early, initializing the driver only partially.
> The driver would be in an unknown state.
>
> If the regulator value is zero, then the internal reference will be zero
> (though that value will be zero for anything less than 1 millivolt).
>
> Fixes: ab0afa65bbc7 ("staging: iio: adc: ad7192: fail probe on get_voltage")
> Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>   drivers/iio/adc/ad7192.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index d3be67aa0522..9da394ad3868 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -951,7 +951,7 @@ static int ad7192_probe(struct spi_device *spi)
>   
>   	voltage_uv = regulator_get_voltage(st->avdd);
>   
> -	if (voltage_uv > 0) {
> +	if (voltage_uv >= 0) {
>   		st->int_vref_mv = voltage_uv / 1000;
>   	} else {
>   		ret = voltage_uv;

More idiomatic would be to check for voltage_uv < 0.

     if (voltage_uv < 0) {
         ret = voltage_uv;
         dev_err(&spi->dev, "Device tree error, reference voltage 
undefined\n");
         goto error_disable_avdd;
     }

     st->int_vref_mv = voltage_uv / 1000;


  reply	other threads:[~2021-05-13  7:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 17:49 [PATCH v3 00/12] ad_sigma_delta: convert all drivers to device-managed Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 01/12] iio: adc: ad7124: Fix missbalanced regulator enable / disable on error Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 02/12] iio: adc: ad7124: Fix potential overflow due to non sequential channel numbers Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 03/12] iio: adc: ad7192: Avoid disabling a clock that was never enabled Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 04/12] iio: adc: ad7192: handle zero Avdd regulator value Alexandru Ardelean
2021-05-13  7:41   ` Lars-Peter Clausen [this message]
2021-05-13  9:11     ` Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 05/12] iio: adc: ad_sigma_delta: introduct devm_ad_sd_setup_buffer_and_trigger() Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 06/12] iio: adc: ad7793: convert to device-managed functions Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 07/12] iio: adc: ad7791: " Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 08/12] iio: adc: ad7780: " Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 09/12] iio: adc: ad7192: use devm_clk_get_optional() for mclk Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 10/12] iio: adc: ad7192: convert to device-managed functions Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 11/12] iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop remove() Alexandru Ardelean
2021-05-12 17:49 ` [PATCH v3 12/12] iio: adc: ad_sigma_delta: remove ad_sd_{setup,cleanup}_buffer_and_trigger() Alexandru Ardelean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a03414-0ead-46a1-f0fe-20f1c22a70b5@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=aardelean@deviqon.com \
    --cc=alexandru.tachici@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@deviqon.com \
    --subject='Re: [PATCH v3 04/12] iio: adc: ad7192: handle zero Avdd regulator value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).