From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, alex.williamson@redhat.com,
vikrams@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: save and restore device state during bus reset
Date: Tue, 13 Sep 2016 19:20:03 -0400 [thread overview]
Message-ID: <46a47bf2-ab39-0ee2-0faf-2f4050f2a89d@codeaurora.org> (raw)
In-Reply-To: <20160913215315.GJ4138@localhost>
On 9/13/2016 5:53 PM, Bjorn Helgaas wrote:
>> + pci_bus_restore(dev->bus);
> This path eventually writes the Bridge Control register:
>
> pci_reset_bridge_secondary_bus
> pcibios_reset_secondary_bus
> pci_reset_secondary_bus
> pci_write_config_word(dev, PCI_BRIDGE_CONTROL, ctrl)
>
> But I think it'd be easy to call this on a non-bridge device, and I
> don't think there's anything in the path that checks whether this is
> actually a bridge. I wonder if we should check that somewhere, or
> maybe even change the interface so it takes a struct pci_bus instead
> of a pci_dev.
>
I'll change it to pci_bus.
>> > +}
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-09-13 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 23:00 [PATCH 1/2] PCI: save and restore device state during bus reset Sinan Kaya
2016-09-01 23:00 ` [PATCH 2/2] PCI: add CRS support to error handling path Sinan Kaya
2016-09-02 0:25 ` Sinan Kaya
2016-09-07 18:56 ` Sinan Kaya
2016-09-13 20:01 ` Bjorn Helgaas
2016-09-13 21:04 ` Sinan Kaya
2016-09-13 21:47 ` Bjorn Helgaas
2016-09-13 22:44 ` Sinan Kaya
2016-09-13 16:42 ` [PATCH 1/2] PCI: save and restore device state during bus reset Bjorn Helgaas
2016-09-13 17:22 ` Sinan Kaya
2016-09-13 21:53 ` Bjorn Helgaas
2016-09-13 23:20 ` Sinan Kaya [this message]
2016-09-13 23:31 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a47bf2-ab39-0ee2-0faf-2f4050f2a89d@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=cov@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).