From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries
Date: Tue, 27 Mar 2018 14:04:54 +0800 [thread overview]
Message-ID: <46ad7f7c-83bb-340b-1de9-486f5cf5ca95@linux.intel.com> (raw)
In-Reply-To: <20180327055859.s2tjsvgdwd7cdkf7@gmail.com>
On 3/27/2018 1:58 PM, Ingo Molnar wrote:
>
> * Jin Yao <yao.jin@linux.intel.com> wrote:
>
>> +#ifdef HAVE_DWARF_SUPPORT
>> +#ifdef HAVE_DWARF_GETLOCATIONS
>> +#ifdef NO_GLIBC
>> +#ifdef HAVE_GTK2_SUPPORT
>> +#ifdef HAVE_LIBAUDIT_SUPPORT
>> +#ifdef HAVE_LIBBFD_SUPPORT
>> +#ifdef HAVE_LIBELF_SUPPORT
>> +#ifdef HAVE_LIBNUMA_SUPPORT
>> +#ifdef NO_LIBPERL
>> +#ifdef NO_LIBPYTHON
>> +#ifdef HAVE_SLANG_SUPPORT
>> +#ifdef HAVE_LIBCRYPTO_SUPPORT
>> +#ifdef HAVE_LIBUNWIND_SUPPORT
>> +#ifdef HAVE_DWARF_SUPPORT
>> +#ifdef HAVE_ZLIB_SUPPORT
>> +#ifdef HAVE_LZMA_SUPPORT
>> +#ifdef HAVE_AUXTRACE_SUPPORT
>> +#ifdef HAVE_LIBBPF_SUPPORT
>
> BTW., it would be nice at this point to fix those 3 outliers that have a negation
> in their library support status macro:
>
>> +#ifdef NO_GLIBC
>> +#ifdef NO_LIBPERL
>> +#ifdef NO_LIBPYTHON
>
> ... and invert them back to the HAVE_* side of the logic:
>
>> +#ifdef HAVE_GLIBC
>> +#ifdef HAVE_LIBPERL
>> +#ifdef HAVE_LIBPYTHON
>
> That should make all related code more consistent and more readable.
>
> Thanks,
>
> Ingo
>
Yes, it's better, thanks!
I will try to convert them to the HAVE_*.
Thanks
Jin Yao
next prev parent reply other threads:[~2018-03-27 6:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 16:07 [PATCH v1 0/3] Support perf -vv Jin Yao
2018-03-26 9:00 ` Andi Kleen
2018-03-26 9:07 ` Jiri Olsa
2018-03-26 13:06 ` Jin, Yao
2018-03-26 16:07 ` [PATCH v1 1/3] perf config: Add -DNO_GLIBC to CFLAGS Jin Yao
2018-03-26 16:07 ` [PATCH v1 2/3] perf version: Print the status of compiled-in libraries Jin Yao
2018-03-26 9:39 ` Jiri Olsa
2018-03-26 13:51 ` Jin, Yao
2018-03-27 3:04 ` Jin, Yao
2018-03-27 12:38 ` Jiri Olsa
2018-03-27 13:26 ` Jin, Yao
2018-03-27 1:44 ` Jin, Yao
2018-03-27 12:56 ` Jiri Olsa
2018-03-27 13:17 ` Jin, Yao
2018-03-27 13:35 ` Jiri Olsa
2018-03-27 5:58 ` Ingo Molnar
2018-03-27 6:04 ` Jin, Yao [this message]
2018-03-26 16:07 ` [PATCH v1 3/3] perf: Support perf -vv Jin Yao
2018-03-27 6:03 ` Ingo Molnar
2018-03-27 6:12 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ad7f7c-83bb-340b-1de9-486f5cf5ca95@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).