From: Stefan Wahren <wahrenst@gmx.net>
To: Daniel Wagner <dwagner@suse.de>, netdev@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Woojung Huh <woojung.huh@microchip.com>,
Marc Zyngier <maz@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle_irq()
Date: Sun, 27 Oct 2019 13:14:41 +0100 [thread overview]
Message-ID: <46b35c32-4383-c630-3c52-b59bf7908c36@gmx.net> (raw)
In-Reply-To: <20191025080413.22665-1-dwagner@suse.de>
Hi Daniel,
Am 25.10.19 um 10:04 schrieb Daniel Wagner:
> ...
>
> Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
> Cc: Woojung Huh <woojung.huh@microchip.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Stefan Wahren <wahrenst@gmx.net>
> Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>
> Hi,
>
> This patch just fixes the warning. There are still problems left (the
> unstable NFS report from me) but I suggest to look at this
> separately. The initial patch to revert all the irqdomain code might
> just hide the problem. At this point I don't know what's going on so I
> rather go baby steps. The revert is still possible if nothing else
> works.
did you ever see this pseudo lan78xx-irqs fire? I examined
/proc/interrupts on RPi 3B+ and always saw a 0.
FWIW you can have:
Tested-by: Stefan Wahren <wahrenst@gmx.net>
for this patch.
Regards
Stefan
next prev parent reply other threads:[~2019-10-27 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 8:04 [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle_irq() Daniel Wagner
2019-10-27 12:14 ` Stefan Wahren [this message]
2019-10-29 16:41 ` Daniel Wagner
2019-10-28 23:35 ` David Miller
2019-11-04 8:57 ` Daniel Wagner
2019-11-04 18:05 ` Stefan Wahren
2019-11-05 9:23 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b35c32-4383-c630-3c52-b59bf7908c36@gmx.net \
--to=wahrenst@gmx.net \
--cc=Jisheng.Zhang@synaptics.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).