From: Archit Taneja <architt@codeaurora.org>
To: Stefan Agner <stefan@agner.ch>, robdclark@gmail.com, airlied@linux.ie
Cc: seanpaul@chromium.org, ssusheel@codeaurora.org, robh@kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt
Date: Sat, 24 Mar 2018 17:07:42 +0530 [thread overview]
Message-ID: <46b36451-8b2c-fdb4-16b3-64a52cb80954@codeaurora.org> (raw)
In-Reply-To: <20180319212632.11260-1-stefan@agner.ch>
On Tuesday 20 March 2018 02:56 AM, Stefan Agner wrote:
> The function dsi_get_cmd_fmt returns enum dsi_cmd_dst_format,
> use the correct enum value also for MIPI_DSI_FMT_RGB666/_PACKED.
>
> This has been discovered using clang:
> drivers/gpu/drm/msm/dsi/dsi_host.c:743:35: warning: implicit conversion
> from enumeration type 'enum dsi_vid_dst_format' to different
> enumeration type 'enum dsi_cmd_dst_format' [-Wenum-conversion]
> case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
> ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Archit
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 0f7324a686ca..d729b2b4b66d 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -740,7 +740,7 @@ static inline enum dsi_cmd_dst_format dsi_get_cmd_fmt(
> switch (mipi_fmt) {
> case MIPI_DSI_FMT_RGB888: return CMD_DST_FORMAT_RGB888;
> case MIPI_DSI_FMT_RGB666_PACKED:
> - case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
> + case MIPI_DSI_FMT_RGB666: return CMD_DST_FORMAT_RGB666;
> case MIPI_DSI_FMT_RGB565: return CMD_DST_FORMAT_RGB565;
> default: return CMD_DST_FORMAT_RGB888;
> }
>
prev parent reply other threads:[~2018-03-24 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 21:26 [PATCH] drm/msm/dsi: use correct enum in dsi_get_cmd_fmt Stefan Agner
2018-03-24 11:37 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b36451-8b2c-fdb4-16b3-64a52cb80954@codeaurora.org \
--to=architt@codeaurora.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=seanpaul@chromium.org \
--cc=ssusheel@codeaurora.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).