From: Laura Abbott <labbott@redhat.com>
To: kernel-hardening@lists.openwall.com
Cc: Jinbum Park <jinb.park7@gmail.com>,
mark.rutland@arm.com, f.fainelli@gmail.com,
keescook@chromium.org, pawel.moll@arm.com,
ard.biesheuvel@linaro.org, kernel-janitors@vger.kernel.org,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
paul.gortmaker@windriver.com, vladimir.murzin@arm.com,
andy.gross@linaro.org, arjan@linux.intel.com, mingo@kernel.org,
linux-arm-kernel@lists.infradead.org, jonathan.austin@arm.com
Subject: Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA
Date: Wed, 18 Jan 2017 15:38:52 -0800 [thread overview]
Message-ID: <46bae2bb-4b4f-158b-6a8d-3737e181ad74@redhat.com> (raw)
In-Reply-To: <20170118223629.GQ27312@n2100.armlinux.org.uk>
On 01/18/2017 02:36 PM, Russell King - ARM Linux wrote:
> On Wed, Jan 18, 2017 at 11:20:54AM -0800, Laura Abbott wrote:
>> On 01/18/2017 05:53 AM, Jinbum Park wrote:
>>> diff --git a/arch/arm/include/asm/cacheflush.h b/arch/arm/include/asm/cacheflush.h
>>> index bdd283b..741e2e8 100644
>>> --- a/arch/arm/include/asm/cacheflush.h
>>> +++ b/arch/arm/include/asm/cacheflush.h
>>> @@ -498,6 +498,16 @@ static inline void set_kernel_text_rw(void) { }
>>> static inline void set_kernel_text_ro(void) { }
>>> #endif
>>>
>>> +#ifdef CONFIG_DEBUG_RODATA_TEST
>>> +extern const int rodata_test_data;
>>> +int rodata_test(void);
>>> +#else
>>> +static inline int rodata_test(void)
>>> +{
>>> + return 0;
>>> +}
>>> +#endif
>>> +
>
> I don't see why this needs to be in cacheflush.h - it doesn't seem to
> have anything to do with cache flushing, and placing it in here means
> that if you change the state of CONFIG_DEBUG_RODATA_TEST, most likely
> the entire kernel gets rebuilt. Please put it in a separate header
> file.
>
cacheflush.h seems to be where all the set_memory_* functions have
ended up. I was just looking at cleaning that up unless someone
beats me to it.
Thanks,
Laura
next prev parent reply other threads:[~2017-01-18 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:53 [PATCH] ARM: mm: add testcases for RODATA Jinbum Park
2017-01-18 14:38 ` Mark Rutland
2017-01-18 19:20 ` Laura Abbott
2017-01-18 21:20 ` Kees Cook
2017-01-18 22:36 ` Russell King - ARM Linux
2017-01-18 23:35 ` Kees Cook
2017-01-18 23:38 ` Laura Abbott [this message]
2017-01-18 23:45 ` [kernel-hardening] " Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46bae2bb-4b4f-158b-6a8d-3737e181ad74@redhat.com \
--to=labbott@redhat.com \
--cc=andy.gross@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arjan@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=jinb.park7@gmail.com \
--cc=jonathan.austin@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).