From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
devicetree@vger.kernel.org
Cc: Hartley Sweeten <hsweeten@visionengravers.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions
Date: Tue, 14 Feb 2023 11:58:11 +0100 [thread overview]
Message-ID: <46d5b6af-23e1-4178-83bc-b4a435b1426e@linaro.org> (raw)
In-Reply-To: <20230212232137.299005-1-alexander.sverdlin@gmail.com>
On 13/02/2023 00:21, Alexander Sverdlin wrote:
> Add device tree bindings for Cirrus Logic EP93xx internal SoCs' I2S and
> AC'97 controllers.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> .../bindings/sound/cirrus,ep9301-ac97.yaml | 47 ++++++++++++++
> .../bindings/sound/cirrus,ep9301-i2s.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 111 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/cirrus,ep9301-ac97.yaml
> create mode 100644 Documentation/devicetree/bindings/sound/cirrus,ep9301-i2s.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,ep9301-ac97.yaml b/Documentation/devicetree/bindings/sound/cirrus,ep9301-ac97.yaml
> new file mode 100644
> index 000000000000..bfa5d392f525
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cirrus,ep9301-ac97.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/cirrus,ep9301-ac97.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cirrus EP93xx AC'97 Controller
> +
> +description: |
> + The AC’97 Controller includes a 5-pin serial interface to an external audio
> + codec.
> +
> +maintainers:
> + - Alexander Sverdlin <alexander.sverdlin@gmail.com>
> +
missing ref to dai-common.yaml
> +properties:
> + compatible:
> + const: cirrus,ep9301-ac97
> +
(...)
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,ep9301-i2s.yaml b/Documentation/devicetree/bindings/sound/cirrus,ep9301-i2s.yaml
> new file mode 100644
> index 000000000000..b47d28dc8389
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cirrus,ep9301-i2s.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/cirrus,ep9301-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cirrus EP93xx I2S Controller
> +
> +description: |
> + The I2S controller is used to stream serial audio data between the external
> + I2S CODECs’, ADCs/DACs, and the ARM Core. The controller supports I2S, Left-
> + and Right-Justified DSP formats.
> +
> +maintainers:
> + - Alexander Sverdlin <alexander.sverdlin@gmail.com>
> +
ref to dai-common
> +properties:
> + compatible:
> + const: cirrus,ep9301-i2s
> +
> + '#sound-dai-cells':
> + const: 0
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 3
maxItems instead
> +
> + clock-names:
> + items:
> + - const: mclk
> + - const: sclk
> + - const: lrclk
The clk suffixes are quite redundant. Don't these inputs have some
meaningful name?
> +
> +required:
> + - compatible
> + - '#sound-dai-cells'
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2s: i2s@80820000 {
> + compatible = "cirrus,ep9301-i2s";
> + #sound-dai-cells = <0>;
> + reg = <0x80820000 0x100>;
> + interrupt-parent = <&vic1>;
> + interrupts = <28>;
> + clocks = <&syscon 29
> + &syscon 30
> + &syscon 31>;
That's one phandle, but you want three, so <>, <>, <>.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-14 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 23:21 [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Alexander Sverdlin
2023-02-12 23:21 ` [PATCH 2/2] ASoC: ep93xx: Add OF support Alexander Sverdlin
2023-02-14 10:58 ` Krzysztof Kozlowski [this message]
2023-02-14 13:02 ` [PATCH 1/2] dt-bindings: sound: ep93xx: Add I2S and AC'97 descriptions Alexander Sverdlin
2023-02-14 14:11 ` Krzysztof Kozlowski
2023-02-14 14:26 ` Alexander Sverdlin
2023-02-14 15:02 ` Mark Brown
2023-02-15 19:16 ` Rob Herring
2023-02-15 19:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d5b6af-23e1-4178-83bc-b4a435b1426e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.sverdlin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).