From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D71C55186 for ; Thu, 23 Apr 2020 01:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67F452074F for ; Thu, 23 Apr 2020 01:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbgDWBI6 (ORCPT ); Wed, 22 Apr 2020 21:08:58 -0400 Received: from mga02.intel.com ([134.134.136.20]:53834 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgDWBI6 (ORCPT ); Wed, 22 Apr 2020 21:08:58 -0400 IronPort-SDR: 7IaR5+f27Z9/Ios7pnrWEAaTUU2Hx6rUqTEo2jJJTbabpg0b5nWNAn67rQRm8YL9vpPi0zhT7c xS+G/U7ll90A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 18:08:57 -0700 IronPort-SDR: Q+SkkfqshQqK1FqTjpGmXe2ftkCsBLCLBPI9Gdflx82m3SnOLJQOBKTgwI7WL8HAAdWeHY70dE 4y8ydrOOboxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,305,1583222400"; d="scan'208";a="365849379" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.151]) ([10.238.4.151]) by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2020 18:08:53 -0700 Subject: Re: [PATCH 2/8] perf metrics: fix parse errors in cascade lake metrics To: Ian Rogers , Andi Kleen Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Haiyan Song , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , LKML , linux-perf-users , Stephane Eranian References: <20200422074809.160248-1-irogers@google.com> <20200422074809.160248-3-irogers@google.com> <20200422143840.GJ608746@tassilo.jf.intel.com> From: "Jin, Yao" Message-ID: <46e803f3-80a4-0d37-9d39-b625b947ac7f@linux.intel.com> Date: Thu, 23 Apr 2020 09:08:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/2020 12:18 AM, Ian Rogers wrote: > On Wed, Apr 22, 2020 at 8:34 AM Ian Rogers wrote: >> >> On Wed, Apr 22, 2020 at 7:38 AM Andi Kleen wrote: >>> >>> On Wed, Apr 22, 2020 at 12:48:03AM -0700, Ian Rogers wrote: >>>> Remove over escaping with \\. >>>> Remove extraneous if 1 if 0 == 1 else 0 else 0. >>> >>> So where do these parse errors happen exactly? Some earlier >>> patches introduced them as regressions? >> >> I'll work to track down a Fixes tag. I can repro the Skylakex errors >> without the test in this series, by doing: >> >> $ perf stat -M DRAM_Read_Latency sleep 1 >> Error: >> The sys_perf_event_open() syscall returned with 22 (Invalid argument) >> for event (cha/event=0x36\,uma >> sk=0x21/). >> /bin/dmesg | grep -i perf may provide additional information. >> I also think some patches introduced this regression. When we rollback to commit 61ec07f5917e (perf vendor events intel: Update all the Intel JSON metrics from TMAM 3.6.), there is no this error on CLX. Thanks Jin Yao >> This was just the escaping issue. I'm less clear on the other cascade >> lake issue, and it is a bit more work for me to test on cascade lake. >> What is "if 1 if 0 == 1 else 0 else 0" trying to do? Perhaps hunting >> for the Fixes will let me know, but it looks like a copy-paste error. >> >>> The original metrics worked without parse errors as far as I know. >> >> The skylake issue above repros on 5.2.17 and so it seems like it is >> broken for a while. The test in this series will prevent this in the >> future, but without this patch that test fails. > > The parse errors were introduced with the metrics, so they've never worked: > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=fd5500989c8f3c3944ac0a144be04bae2506f7ba > > I will send out a v2 with Fixes in the commit message but wanted to > wait in case there was any more feedback. In particular the fixes to > the new test and expr parser lex code. The lex code wasn't broken at > the time the metrics were added and should be working again after this > patch set. > > Thanks, > Ian > >>> If it fixes something earlier it would need Fixes: tags. >> >> Working on it. Thanks for the input! >> >> Ian >> >>> -Andi