From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
Christian Hewitt <christianshewitt@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC
Date: Wed, 29 May 2019 16:17:52 +0200 [thread overview]
Message-ID: <471c24af-ad63-3986-6265-1cf62ce45cb0@baylibre.com> (raw)
In-Reply-To: <CAFBinCBJwVT0uMx--NPuuAYS7k2Zx-X-Ew+qNmRQiPV+Cmv=KA@mail.gmail.com>
On 27/05/2019 20:15, Martin Blumenstingl wrote:
> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Christian Hewitt <christianshewitt@gmail.com>
>>
>> Enable SARADC on Wetek Boards.
> as far I as remember there's a story behind this (and it would be nice
> to have it documented here):
> some of the SCPI firmware revisions don't enable the SAR ADC clock
> when reading the SoCs temperature.
> if the SAR ADC is disabled in Linux then the common clock framework
> will disable the SAR ADC clock.
> now, when the SCPI firmware uses the SAR ADC to read the SoC
> temperature we only get garbage.
>
> enabling the SAR ADC in Linux "fixes" this issue
Yes seems to be this issue solved here
>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> with that:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
next prev parent reply other threads:[~2019-05-29 14:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 13:21 [PATCH 00/10] arm64: meson-gx: misc fixes Neil Armstrong
2019-05-27 13:21 ` [PATCH 01/10] arm64: dts: meson-gxm-khadas-vim2: fix gpio-keys-polled node Neil Armstrong
2019-05-27 18:32 ` Martin Blumenstingl
2019-06-06 20:00 ` Kevin Hilman
2019-06-07 13:01 ` Neil Armstrong
2019-06-07 16:59 ` Kevin Hilman
2019-05-27 13:21 ` [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support Neil Armstrong
2019-05-27 18:36 ` Martin Blumenstingl
2019-05-29 10:25 ` Neil Armstrong
2019-05-29 18:08 ` Martin Blumenstingl
2019-06-03 8:57 ` Neil Armstrong
2019-06-03 11:57 ` Christian Hewitt
2019-06-06 19:52 ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC Neil Armstrong
2019-05-27 18:15 ` Martin Blumenstingl
2019-05-29 14:17 ` Neil Armstrong [this message]
2019-05-27 13:21 ` [PATCH 04/10] arm64: dts: meson-gxbb-wetek: enable bluetooth Neil Armstrong
2019-05-27 18:19 ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 05/10] arm64: dts: meson-gxbb-vega-s95: fix regulators Neil Armstrong
2019-05-27 18:21 ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 06/10] arm64: dts: meson-gxbb-vega-s95: add HDMI nodes Neil Armstrong
2019-05-27 18:23 ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 07/10] arm64: dts: meson-gxbb-vega-s95: enable CEC Neil Armstrong
2019-05-27 18:22 ` Martin Blumenstingl
2019-05-27 13:21 ` [PATCH 08/10] arm64: dts: meson-gxbb-vega-s95: enable SARADC Neil Armstrong
2019-05-27 18:24 ` Martin Blumenstingl
2019-05-29 14:17 ` Neil Armstrong
2019-05-27 13:21 ` [PATCH 09/10] arm64: dts: meson-gxbb-vega-s95: fix WiFi/BT module support Neil Armstrong
2019-05-27 18:27 ` Martin Blumenstingl
2019-05-27 13:22 ` [PATCH 10/10] arm64: dts: meson-gxbb-vega-s95: add ethernet PHY interrupt Neil Armstrong
2019-05-27 18:25 ` Martin Blumenstingl
2019-06-03 22:25 ` [PATCH 00/10] arm64: meson-gx: misc fixes Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471c24af-ad63-3986-6265-1cf62ce45cb0@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).