From: Florian Fainelli <f.fainelli@gmail.com>
To: Ray Jui <ray.jui@broadcom.com>, Wen Yang <wen.yang99@zte.com.cn>,
linux-kernel@vger.kernel.org
Cc: wang.yi59@zte.com.cn, Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node_put
Date: Fri, 8 Mar 2019 10:50:07 -0800 [thread overview]
Message-ID: <472373f4-fc8e-3c8d-a2a3-e6cba261e2a7@gmail.com> (raw)
In-Reply-To: <67d1be96-ad8a-a453-996f-731a363677ae@broadcom.com>
On 3/5/19 9:24 AM, Ray Jui wrote:
>
>
> On 3/5/2019 3:33 AM, Wen Yang wrote:
>> The call to of_get_next_child returns a node pointer with refcount
>> incremented thus it must be explicitly decremented after the last
>> usage.
>>
>> Detected by coccinelle with the following warnings:
>> ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.
>>
>> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>> Cc: Florian Fainelli <f.fainelli@gmail.com>
>> Cc: Ray Jui <rjui@broadcom.com>
>> Cc: Scott Branden <sbranden@broadcom.com>
>> Cc: bcm-kernel-feedback-list@broadcom.com
>> Cc: Russell King <linux@armlinux.org.uk>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> v2->v1: add a missing space between "adding" and "missing"
>>
>> arch/arm/mach-bcm/board_bcm281xx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-bcm/board_bcm281xx.c b/arch/arm/mach-bcm/board_bcm281xx.c
>> index b81bb38..1238ac8 100644
>> --- a/arch/arm/mach-bcm/board_bcm281xx.c
>> +++ b/arch/arm/mach-bcm/board_bcm281xx.c
>> @@ -38,6 +38,7 @@ static void bcm281xx_restart(enum reboot_mode mode, const char *cmd)
>> return;
>> }
>> base = of_iomap(np_wdog, 0);
>> + of_node_put(np_wdog);
>> if (!base) {
>> pr_emerg("Couldn't map brcm,kona-wdt\n");
>> return;
>>
>
> Change looks good to me. Thanks!
>
> Acked-by: Ray Jui <ray.jui@broadcom.com>
>
Squashed this patch and "[PATCH 1/4] ARM: brcmstb: fix a leaked
reference by adding missing of_node_put" into the same commit:
https://github.com/Broadcom/stblinux/commit/ff98f8f6083a7f317463f538e9a21822e1128657
thanks Wen!
--
Florian
next prev parent reply other threads:[~2019-03-08 18:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 11:33 [PATCH v2 01/15] ARM: actions: fix a leaked reference by adding missing of_node_put Wen Yang
2019-03-05 11:33 ` [PATCH v2 02/15] ARM: bcm: " Wen Yang
2019-03-05 17:24 ` Ray Jui
2019-03-08 18:50 ` Florian Fainelli [this message]
2019-03-05 11:33 ` [PATCH v2 03/15] ARM: exynos: " Wen Yang
2019-03-19 20:39 ` Krzysztof Kozlowski
2019-03-05 11:33 ` [PATCH v2 04/15] ARM: hisi: " Wen Yang
2019-04-05 11:26 ` Markus Elfring
2019-03-05 11:33 ` [PATCH v2 05/15] ARM: imx51: " Wen Yang
2019-03-06 2:58 ` Shawn Guo
2019-03-05 11:33 ` [PATCH v2 06/15] arm: npcm: " Wen Yang
2019-03-06 12:02 ` Avi Fishman
2019-03-05 11:33 ` [PATCH v2 07/15] ARM: rockchip: " Wen Yang
2019-04-23 17:48 ` Heiko Stuebner
2019-03-05 11:33 ` [PATCH v2 08/15] ARM: shmobile: " Wen Yang
2019-03-08 12:07 ` Simon Horman
2019-03-05 11:34 ` [PATCH v2 09/15] ARM: socfpga: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 10/15] ARM: sunxi: " Wen Yang
2019-03-05 11:59 ` maxime.ripard
2019-03-05 11:34 ` [PATCH v2 11/15] ARM: versatile: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 12/15] ARM: vexpress: " Wen Yang
2019-03-05 11:39 ` Sudeep Holla
2019-03-05 11:34 ` [PATCH v2 13/15] ARM: zynq: " Wen Yang
2019-03-05 11:34 ` [PATCH v2 14/15] arm64: cpu_ops: " Wen Yang
2019-04-01 15:37 ` Will Deacon
[not found] ` <201904031356099956278@zte.com.cn>
2019-04-03 12:44 ` 答复: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked reference byadding " Will Deacon
2019-03-05 11:34 ` [PATCH v2 15/15] ARM: axxia: fix a leaked reference by adding " Wen Yang
2019-03-05 11:40 ` [PATCH v2 01/15] ARM: actions: " Russell King - ARM Linux admin
2019-03-09 2:17 ` Manivannan Sadhasivam
2019-03-09 8:14 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472373f4-fc8e-3c8d-a2a3-e6cba261e2a7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ray.jui@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).