From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbcGAK6q (ORCPT ); Fri, 1 Jul 2016 06:58:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33895 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751912AbcGAK6p (ORCPT ); Fri, 1 Jul 2016 06:58:45 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: oberpar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [Patch v002] gcov: Added support for >=gcc-6 To: Florian Meier References: Cc: linux-kernel@vger.kernel.org From: Peter Oberparleiter Date: Fri, 1 Jul 2016 12:58:47 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070110-0032-0000-0000-000001E26E39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070110-0033-0000-0000-00001B9ED180 Message-Id: <47279bc9-d179-5c14-3fce-ed88135e6bea@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-01_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607010108 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.07.2016 11:06, Florian Meier wrote: > Signed-off-by: Florian Meier > --- > kernel/gcov/gcc_4_7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c > index e25e92f..6a5c239 100644 > --- a/kernel/gcov/gcc_4_7.c > +++ b/kernel/gcov/gcc_4_7.c > @@ -18,7 +18,7 @@ > #include > #include "gcov.h" > > -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1 > +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1) > #define GCOV_COUNTERS 10 > #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9 > #define GCOV_COUNTERS 9 > Content looks good but the patch doesn't apply due to whitespace issues. Could you send a version with the tabs remaining intact? Also a slightly more verbose patch message (similar to the one of the original patch) would be helpful. -- Peter Oberparleiter Linux on z Systems Development - IBM Germany