linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org,
	dave.jiang@intel.com, tony.luck@intel.com,
	wajdi.k.feghali@intel.com, james.guilford@intel.com,
	kanchana.p.sridhar@intel.com, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH 12/16] crypto: iaa - Add support for iaa_crypto deflate compression algorithm
Date: Fri, 17 Mar 2023 13:28:54 -0500	[thread overview]
Message-ID: <472cf360819845616daea229e9884cf9febf06e9.camel@linux.intel.com> (raw)
In-Reply-To: <ZBPVxDSESihZ12tD@gondor.apana.org.au>

Hi Herbert,

On Fri, 2023-03-17 at 10:51 +0800, Herbert Xu wrote:
> On Mon, Mar 06, 2023 at 12:52:22PM -0600, Tom Zanussi wrote:
> > 
> > +static struct crypto_alg iaa_comp_deflate = {
> > +       .cra_name               = "deflate",
> > +       .cra_driver_name        = "iaa_crypto",
> > +       .cra_flags              = CRYPTO_ALG_TYPE_COMPRESS,
> > +       .cra_priority           = IAA_ALG_PRIORITY,
> > +       .cra_module             = THIS_MODULE,
> > +       .cra_u                  = {
> > +       .compress = {
> > +                       .coa_compress   = iaa_comp_compress,
> > +                       .coa_decompress = iaa_comp_decompress
> > +               }
> > +       }
> > +};
> 
> Please add any new code using the legacy compression interface.
> We're trying to phase them out.
> 
> If your user is still using the legacy interface, they should
> be converted instead.
> 

OK, I'll just remove this interface.  It was added so IAA could be used
with zram, which still uses the old interface.

I'll play around with seeing what it would take to get zram to use the
async interface ala zswap, but I'm guessing there may be a reason it
hasn't been converted yet...

Thanks,

Tom

> Thanks,


  reply	other threads:[~2023-03-17 18:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 18:52 [PATCH 00/16] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Tom Zanussi
2023-03-06 18:52 ` [PATCH 01/16] dmaengine: idxd: add wq driver name support for accel-config user tool Tom Zanussi
2023-03-07 13:43   ` Fenghua Yu
2023-03-07 14:50     ` Tom Zanussi
2023-03-06 18:52 ` [PATCH 02/16] dmaengine: idxd: add external module driver support for dsa_bus_type Tom Zanussi
2023-03-06 18:52 ` [PATCH 03/16] dmaengine: idxd: Export drv_enable/disable and related functions Tom Zanussi
2023-03-06 18:52 ` [PATCH 04/16] dmaengine: idxd: Export descriptor management functions Tom Zanussi
2023-03-06 18:52 ` [PATCH 05/16] dmaengine: idxd: Export wq resource " Tom Zanussi
2023-03-06 18:52 ` [PATCH 06/16] dmaengine: idxd: Add private_data to struct idxd_wq Tom Zanussi
2023-03-06 18:52 ` [PATCH 07/16] dmaengine: idxd: add callback support for iaa crypto Tom Zanussi
2023-03-06 18:52 ` [PATCH 08/16] crypto: iaa - Add IAA Compression Accelerator Documentation Tom Zanussi
2023-03-06 18:52 ` [PATCH 09/16] crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core Tom Zanussi
2023-03-06 18:52 ` [PATCH 10/16] crypto: iaa - Add per-cpu workqueue table with rebalancing Tom Zanussi
2023-03-06 18:52 ` [PATCH 11/16] crypto: iaa - Add compression mode management along with fixed mode Tom Zanussi
2023-03-06 18:52 ` [PATCH 12/16] crypto: iaa - Add support for iaa_crypto deflate compression algorithm Tom Zanussi
2023-03-17  2:51   ` Herbert Xu
2023-03-17 18:28     ` Tom Zanussi [this message]
2023-03-06 18:52 ` [PATCH 13/16] crypto: iaa - Add support for default IAA 'canned' compression mode Tom Zanussi
2023-03-06 18:52 ` [PATCH 14/16] crypto: iaa - Add support for iaa_crypto async deflate compression algorithm Tom Zanussi
2023-03-06 18:52 ` [PATCH 15/16] crypto: iaa - Add irq support for the crypto async interface Tom Zanussi
2023-03-06 18:52 ` [PATCH 16/16] crypto: iaa - Add IAA Compression Accelerator stats Tom Zanussi
2023-03-07  4:20 ` [PATCH 00/16] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Herbert Xu
2023-03-07 14:44   ` Tom Zanussi
2023-03-07 15:54   ` Dave Jiang
2023-03-09 10:14     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472cf360819845616daea229e9884cf9febf06e9.camel@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.guilford@intel.com \
    --cc=kanchana.p.sridhar@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    --cc=wajdi.k.feghali@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).