From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Felipe Balbi <balbi@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] usb: phy: generic: Support enabling/disabling VBUS
Date: Tue, 5 Apr 2022 11:06:10 -0400 [thread overview]
Message-ID: <4737966b-a72f-8f4b-e9bc-a38a3f96b6da@seco.com> (raw)
In-Reply-To: <YkxaIK/y+7H8HgwZ@kroah.com>
On 4/5/22 11:02 AM, Greg Kroah-Hartman wrote:
> On Tue, Apr 05, 2022 at 10:51:34AM -0400, Sean Anderson wrote:
>>
>>
>> On 1/14/22 12:09 PM, Sean Anderson wrote:
>> > The generic USB phy has had VBUS-related code for a long time, but it
>> > has always been broken, since the regulator was never gotten from the
>> > device tree. However, the support itself seems not very useful, since
>> > e.g. usb_phy_vbus_on/off has no users and usb_phy_set_power is only
>> > used by gadgets to make sure they don't draw too much current. Instead,
>> > use the VBUS regulator to implement otg_set_vbus, which is called from
>> > several drivers. This results in a change in semantics of VBUS, but
>> > since support was always broken I don't think this will have any affect.
>> >
>> >
>> > Sean Anderson (4):
>> > dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator
>> > usb: phy: generic: Get the vbus supply
>> > usb: phy: generic: Implement otg->set_vbus
>> > usb: phy: generic: Disable vbus on removal
>> >
>> > .../bindings/usb/usb-nop-xceiv.yaml | 8 +--
>> > drivers/usb/phy/phy-generic.c | 55 +++++++++----------
>> > 2 files changed, 31 insertions(+), 32 deletions(-)
>> >
>>
>> ping?
>>
>> When this was submitted I got an email saying that the merge window was
>> closed... but I think it has opened and closed again during the
>> intervening time.
>
> It opened yesterday. Please give us a chance to catch up.
Ah, sorry. I thought this series had just gotten lost.
> While that happens, please take the time to review other changes on the
> mailing lists, we can always use the help.
Noted.
--Sean
prev parent reply other threads:[~2022-04-06 1:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 17:09 [PATCH 0/4] usb: phy: generic: Support enabling/disabling VBUS Sean Anderson
2022-01-14 17:09 ` [PATCH 1/4] dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator Sean Anderson
2022-01-15 17:22 ` Rob Herring
2022-01-14 17:09 ` [PATCH 2/4] usb: phy: generic: Get the vbus supply Sean Anderson
2022-01-14 17:09 ` [PATCH 3/4] usb: phy: generic: Implement otg->set_vbus Sean Anderson
2022-01-14 17:09 ` [PATCH 4/4] usb: phy: generic: Disable vbus on removal Sean Anderson
2022-04-05 14:51 ` [PATCH 0/4] usb: phy: generic: Support enabling/disabling VBUS Sean Anderson
2022-04-05 15:02 ` Greg Kroah-Hartman
2022-04-05 15:06 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4737966b-a72f-8f4b-e9bc-a38a3f96b6da@seco.com \
--to=sean.anderson@seco.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).