From: "Heiko Stübner" <heiko@sntech.de>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>, Liang Chen <cl@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Michael Riesch <michael.riesch@wolfvision.net>,
Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH 4/5] arm64: dts: rockchip: rk3568-evb1-v10: add pinctrl and alias to emmc node
Date: Tue, 03 Aug 2021 22:47:07 +0200 [thread overview]
Message-ID: <4739137.8F6SAcFxjW@diego> (raw)
In-Reply-To: <20210803185309.10013-5-michael.riesch@wolfvision.net>
Am Dienstag, 3. August 2021, 20:53:08 CEST schrieb Michael Riesch:
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> index f3fd4a6813a2..3ac70a8183c4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> @@ -16,6 +16,7 @@
> aliases {
> ethernet0 = &gmac0;
> ethernet1 = &gmac1;
> + emmc = &sdhci;
what is this supposed to do?
I don't think "emmc" is defined as any form of alias, instead
mmc aliases generally are more "mmcX" for X 0,1,etc .
Heiko
> };
>
> chosen: chosen {
> @@ -347,6 +348,8 @@
> bus-width = <8>;
> max-frequency = <200000000>;
> non-removable;
> + pinctrl-names = "default";
> + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
> status = "okay";
> };
>
>
next prev parent reply other threads:[~2021-08-03 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 18:53 [PATCH 0/5] arm64: dts: rockchip: rk3568-evb1-v10: add sd card support Michael Riesch
2021-08-03 18:53 ` [PATCH 1/5] arm64: dts: rockchip: rk3568-evb1-v10: add regulators of rk809 pmic Michael Riesch
2021-08-03 18:53 ` [PATCH 2/5] arm64: dts: rockchip: enable io domains for rk356x Michael Riesch
2021-08-03 18:53 ` [PATCH 3/5] arm64: dts: rockchip: rk3568-evb1-v10: enable io domains Michael Riesch
2021-08-03 18:53 ` [PATCH 4/5] arm64: dts: rockchip: rk3568-evb1-v10: add pinctrl and alias to emmc node Michael Riesch
2021-08-03 20:47 ` Heiko Stübner [this message]
2021-08-03 18:53 ` [PATCH 5/5] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card Michael Riesch
2021-08-03 20:48 ` Heiko Stübner
2021-08-04 10:03 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4739137.8F6SAcFxjW@diego \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).