linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	info@andromedabox.org, linux-kernel@vger.kernel.org,
	Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
Date: Thu, 23 Feb 2017 15:11:46 +0100	[thread overview]
Message-ID: <473e4976-77eb-4b67-e874-ae6bd717ddaa@suse.de> (raw)
In-Reply-To: <20170222184734.wmkbzfsz4yklofcg@sirena.org.uk>

Am 22.02.2017 um 19:47 schrieb Mark Brown:
> On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote:
> 
> This is patch 4 of 8, what's going on with dependencies here?

No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64.

It compiled without this (just Kconfig warnings), so this could go
through the appropriate sound tree as a cleanup.

> Please use subject lines matching the style for the subsystem.  This
> makes it easier for people to identify relevant patches.

Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM,
which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC
can be found in "ALSA for SoC audio support" section.', which confused
me about whether or not this is an ASoC compliant driver if it selects a
non-ASoC symbol.

>>  config SND_MMP_SOC
>> -	bool "Soc Audio for Marvell MMP chips"
>> -	depends on ARCH_MMP
>> +	bool "SoC Audio for Marvell MMP chips"
>> +	depends on ARCH_MMP && ARM
> 
> There are no obvious build time architecture dependencies for this
> driver, shouldn't we have an || COMPILE_TEST in here?

I'm the wrong person to answer that - the symbol relies on
architecture-specific SND_ARM, and my understanding was that the code
still relies on platform data, therefore it did not seem worthwhile to
just disable inapplicable dependencies such as MMP_SRAM
(arch/arm/mach-mmp/; superseded by DT mmio-sram) or SND_ARM.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2017-02-23 14:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  2:29 [PATCH v2 0/8] ARM64: Initial Marvell IAP140 enablement Andreas Färber
2017-02-22  2:29 ` [PATCH v2 1/8] Documentation: arm: Marvell: Document IAP140 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 2/8] tty: serial: Suppress deprecated SERIAL_PXA on arm64 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 3/8] tty: serial: 8250_pxa: Implement mmp earlycon Andreas Färber
2017-02-22  2:29 ` [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Andreas Färber
2017-02-22 18:47   ` Mark Brown
2017-02-23 14:11     ` Andreas Färber [this message]
2017-02-23 14:24       ` Takashi Iwai
2017-02-23 14:45         ` Andreas Färber
2017-02-22  2:29 ` [PATCH v2 5/8] ARM64: Prepare Marvell IAP140 aka PXA1908 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 6/8] Documentation: devicetree: arm: marvell: Document IAP140 Andreas Färber
2017-02-27 22:31   ` Rob Herring
2017-02-22  2:29 ` [PATCH v2 7/8] ARM64: dts: marvell: Add IAP140 and Andromeda Box Edge Andreas Färber
2017-02-22  2:29 ` [PATCH v2 8/8] ARM64: dts: marvell: iap140-andromeda-box-edge: Add uart0 clock Andreas Färber
2017-02-22 13:34 ` [PATCH v2 0/8] ARM64: Initial Marvell IAP140 enablement Rob Herring
2017-02-22 16:43   ` Andreas Färber
2017-02-22 16:48     ` Andreas Färber
2017-02-22 19:27     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473e4976-77eb-4b67-e874-ae6bd717ddaa@suse.de \
    --to=afaerber@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=info@andromedabox.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).