From: Gabriel C <nix.or.die@googlemail.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Laurent Riffard <laurent.riffard@free.fr>,
Hannes Reinecke <hare@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: 2.6.24-rc3-mm1: I/O error, system hangs
Date: Sat, 24 Nov 2007 19:28:01 +0100 [thread overview]
Message-ID: <47486D31.3060303@googlemail.com> (raw)
In-Reply-To: <474868B6.8040004@googlemail.com>
Gabriel C wrote:
> James Bottomley wrote:
>> On Sat, 2007-11-24 at 18:54 +0100, Gabriel C wrote:
>>> James Bottomley wrote:
>>>> On Sat, 2007-11-24 at 13:57 +0100, Laurent Riffard wrote:
>>>>> Le 24.11.2007 07:42, James Bottomley a écrit :
>>>>>> On Fri, 2007-11-23 at 18:52 +0100, Laurent Riffard wrote:
>>>>>>> Le 23.11.2007 12:38, Hannes Reinecke a écrit :
>>>>>>>> Hannes Reinecke wrote:
>>>>>>>>> Laurent Riffard wrote:
>>>>>>>>>> Le 21.11.2007 23:41, Andrew Morton a écrit :
>>>>>>>>>>> On Wed, 21 Nov 2007 22:45:22 +0100
>>>>>>>>>>> Laurent Riffard <laurent.riffard@free.fr> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Le 21.11.2007 05:45, Andrew Morton a écrit :
>>>>>>>>>>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc3/2.6.24-rc3-mm1/
>>>>>>>>>>>> Hello,
>>>>>>>>>>>>
>>>>>>>>>>>> My system hangs shortly after I logged in Gnome desktop. SysRq-W shows
>>>>>>>>>>>> that a bunch of task are blocked in "D" state, they seem to wait for
>>>>>>>>>>>> some I/O completion. I can try to hand-copy some data if requested.
>>>>>>>>>>>>
>>>>>>>>>>>> I found these messages in dmesg:
>>>>>>>>>>>>
>>>>>>>>>>>> ~$ grep -C2 end_request dmesg-2.6.24-rc3-mm1
>>>>>>>>>>>> EXT3-fs: mounted filesystem with ordered data mode.
>>>>>>>>>>>> sd 0:0:0:0: [sda] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK
>>>>>>>>>>>> end_request: I/O error, dev sda, sector 16460
>>>>>>>>>>>> ReiserFS: sda7: found reiserfs format "3.6" with standard journal
>>>>>>>>>>>> ReiserFS: sda7: using ordered data mode
>>>>>>>>>>>> --
>>>>>>>>>>>> ReiserFS: sda7: Using r5 hash to sort names
>>>>>>>>>>>> sd 0:0:1:0: [sdb] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK
>>>>>>>>>>>> end_request: I/O error, dev sdb, sector 19632
>>>>>>>>>>>> sd 0:0:1:0: [sdb] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK
>>>>>>>>>>>> end_request: I/O error, dev sdb, sector 40037363
>>>>>>>>>>>> Adding 1048568k swap on /dev/mapper/vglinux1-lvswap. Priority:-1 extents:1 across:1048568k
>>>>>>>>>>>> lp0: using parport0 (interrupt-driven).
>>>>>>>>>>>>
>>>>>>>>>>>> These errors occur *only* with 2.6.24-rc3-mm1, they are 100% reproducible.
>>>>>>>>>>>> 2.6.24-rc3 and 2.6.24-rc2-mm1 are fine.
>>>>>>>>>>>>
>>>>>>>>>>>> Maybe something is broken in pata_via driver ?
>>>>>>>>>>>>
>>>>>>>>>>> Could be - libata-reimplement-ata_acpi_cbl_80wire-using-ata_acpi_gtm_xfermask.patch
>>>>>>>>>>> and pata_amd-pata_via-de-couple-programming-of-pio-mwdma-and-udma-timings.patch
>>>>>>>>>>> touch pata_via.c.
>>>>>>>>>> None of the above...
>>>>>>>>>>
>>>>>>>>>> I did a bisection, it spotted git-scsi-misc.patch.
>>>>>>>>>> I just run 2.6.24-rc3-mm1 + revert-git-scsi-misc.patch, and it works fine.
>>>>>>>>>>
>>>>>>>>>> I guess commit 8655a546c83fc43f0a73416bbd126d02de7ad6c0 "[SCSI] Do not
>>>>>>>>>> requeue requests if REQ_FAILFAST is set" is the real culprit. The other
>>>>>>>>>> commits are touching documentation or drivers I don't use. I'll try
>>>>>>>>>> to revert only this one this evening.
>>>>>>> I can confirm : reverting commit 8655a546c83fc43f0a73416bbd126d02de7ad6c0
>>>>>>> does fix the problem.
>>>>>>>
>>>>>>>>> Hmm. Weird. I'll have a look into it. Apparently I'll be returning an error where
>>>>>>>>> I shouldn't. Checking ...
>>>>>>>>>
>>>>>>>> Ok, found it. We are blocking even special commands (ie requests with PREEMPT not set)
>>>>>>>> when FAILFAST is set. Which is clearly wrong. The attached patch fixes this.
>>>>>>> Sorry, it's not enough. 2.6.24-rc3-mm1 + your patch still hangs with I/O errors.
>>>>>> I think the problem is the way we treat BLOCKED and QUIESCED (the latter
>>>>>> is the state that the domain validation uses and which we cannot kill
>>>>>> fastfail on). It's definitely wrong to kill fastfail requests when the
>>>>>> state is QUIESCE.
>>>>>>
>>>>>> This patch (which is applied on top of Hannes original) separates the
>>>>>> BLOCK and QUIESCE states correctly ... does this fix the problem?
>>>>> No, it doesn't help... (2.6.24-rc3-mm1 + your patch still has problems)
>>>> OK, could you post dmesgs again, please. I actually tested this with an
>>>> aic79xx card, and for me it does cause Domain Validation to succeed
>>>> again.
>>>>
>>> Are the patches indeed to fix that problem as well ?
>>>
>>> http://lkml.org/lkml/2007/11/23/5
>> That dmesg is from an unknown SCSI card exhibiting Domain Validation
>> problems, so it's a reasonable probability, yes ... but you'll need the
>> additional hack I just did to prevent further intermittent failures.
>
> My controller is:
>
> 03:0e.0 SCSI storage controller [0100]: Adaptec AIC-7892P U160/m [9005:008f] (rev 02)
>
> I'll try the patches in a bit.
With your patches my problem(s) are solved. Domain Validation works again.
...
[ 32.179521] scsi 0:0:0:0: Direct-Access SEAGATE ST318406LW 0109 PQ: 0 ANSI: 3
[ 32.179540] scsi0:A:0:0: Tagged Queuing enabled. Depth 32
[ 32.179554] target0:0:0: Beginning Domain Validation
[ 32.188553] target0:0:0: wide asynchronous
[ 32.195302] target0:0:0: FAST-80 WIDE SCSI 160.0 MB/s DT (12.5 ns, offset 63)
[ 32.206510] target0:0:0: Ending Domain Validation
[ 32.211699] scsi 0:0:1:0: Direct-Access FUJITSU MAH3182MP 0114 PQ: 0 ANSI: 4
[ 32.211707] scsi0:A:1:0: Tagged Queuing enabled. Depth 32
[ 32.211717] target0:0:1: Beginning Domain Validation
[ 32.213980] target0:0:1: wide asynchronous
[ 32.215682] target0:0:1: FAST-80 WIDE SCSI 160.0 MB/s DT (12.5 ns, offset 127)
[ 32.220205] target0:0:1: Ending Domain Validation
...
Thx James :)
Gabriel
next prev parent reply other threads:[~2007-11-24 18:28 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 4:45 2.6.24-rc3-mm1 Andrew Morton
2007-11-21 5:51 ` 2.6.24-rc3-mm1 Dave Young
2007-11-21 6:00 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-21 6:03 ` 2.6.24-rc3-mm1 Dave Young
2007-11-21 6:15 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-21 6:22 ` 2.6.24-rc3-mm1 Dave Young
2007-11-21 18:35 ` 2.6.24-rc3-mm1 Kirill A. Shutemov
2007-11-21 22:25 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-26 18:48 ` 2.6.24-rc3-mm1 Rik van Riel
2007-11-26 19:33 ` 2.6.24-rc3-mm1 Jiri Slaby
2007-11-21 5:56 ` 2.6.24-rc3-mm1 - Build Failure on S390x Kamalesh Babulal
2007-11-21 6:04 ` Andrew Morton
2007-11-21 5:58 ` 2.6.24-rc3-mm1 KAMEZAWA Hiroyuki
2007-11-21 6:08 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-21 12:49 ` 2.6.24-rc3-mm1 Rene Herman
2007-11-21 6:11 ` 2.6.24-rc3-mm1 - Kernel Panic on IO-APIC Kamalesh Babulal
2007-11-21 6:18 ` Andrew Morton
2007-11-21 9:22 ` Kamalesh Babulal
2007-11-21 9:29 ` Andrew Morton
2007-11-21 9:43 ` Kamalesh Babulal
2007-11-21 19:33 ` Torsten Kaiser
2007-11-22 10:04 ` Kirill A. Shutemov
2007-11-21 19:22 ` Len Brown
2007-11-21 19:48 ` Torsten Kaiser
2007-11-24 0:49 ` Alexey Dobriyan
2007-11-26 19:39 ` Rik van Riel
2007-11-26 20:33 ` Andrew Morton
2007-11-26 20:45 ` Ingo Molnar
2007-11-26 22:08 ` Jiri Slaby
2007-11-26 22:17 ` Andrew Morton
2007-11-26 22:22 ` Jiri Slaby
2007-11-26 23:14 ` Jiri Slaby
2007-11-26 23:28 ` Andrew Morton
2007-11-27 17:50 ` Rik van Riel
2007-11-26 20:54 ` Rik van Riel
2007-11-26 20:56 ` Christoph Lameter
2007-11-21 8:06 ` 2.6.24-rc3-mm1- powerpc link failure Kamalesh Babulal
2007-11-21 22:52 ` Stephen Rothwell
2007-11-21 8:24 ` 2.6.24-rc3-mm1 make headers_check fails Kamalesh Babulal
2007-11-21 0:32 ` Andrew Morton
2007-11-21 8:41 ` Kamalesh Babulal
2007-11-21 8:44 ` Avi Kivity
2007-11-21 8:52 ` Robert P. J. Day
2007-11-21 9:04 ` Andrew Morton
2007-11-21 9:06 ` Robert P. J. Day
2007-11-21 9:58 ` Sam Ravnborg
2007-11-21 10:00 ` Avi Kivity
2007-11-21 10:17 ` Avi Kivity
2007-11-21 10:31 ` Robert P. J. Day
2007-11-28 5:02 ` Andrew Morton
2007-12-02 8:56 ` Avi Kivity
2007-11-24 14:34 ` Adrian Bunk
2007-11-21 8:42 ` 2.6.24-rc3-mm1 (sync is slow ?) KAMEZAWA Hiroyuki
2007-11-21 8:49 ` Andrew Morton
2007-11-22 3:06 ` KAMEZAWA Hiroyuki
2007-11-24 12:04 ` kosaki
2007-11-24 18:04 ` Gabriel C
2007-11-26 7:06 ` KAMEZAWA Hiroyuki
2007-11-21 8:49 ` KAMEZAWA Hiroyuki
2007-11-21 18:23 ` 2.6.24-rc3-mm1: usb mouse doesn't work Kirill A. Shutemov
2007-11-21 22:22 ` Andrew Morton
2007-11-22 10:17 ` Kirill A. Shutemov
2007-11-22 17:07 ` [linux-usb-devel] " Alan Stern
2007-11-22 17:41 ` Marin Mitov
2007-11-23 2:51 ` Alan Stern
2007-11-23 5:19 ` Kirill A. Shutemov
2007-11-23 16:21 ` Alan Stern
2007-12-31 21:06 ` Alan Stern
2007-11-21 21:45 ` 2.6.24-rc3-mm1: I/O error, system hangs Laurent Riffard
2007-11-21 22:41 ` Andrew Morton
2007-11-23 7:29 ` Laurent Riffard
2007-11-23 7:51 ` Hannes Reinecke
2007-11-23 11:38 ` Hannes Reinecke
2007-11-23 17:52 ` Laurent Riffard
2007-11-24 6:42 ` James Bottomley
2007-11-24 12:57 ` Laurent Riffard
2007-11-24 13:26 ` James Bottomley
2007-11-24 17:54 ` Gabriel C
2007-11-24 18:04 ` James Bottomley
2007-11-24 18:08 ` Gabriel C
2007-11-24 18:28 ` Gabriel C [this message]
2007-11-24 22:59 ` Laurent Riffard
2007-11-25 7:37 ` James Bottomley
2007-11-25 20:39 ` Laurent Riffard
2007-11-28 21:38 ` Laurent Riffard
2007-11-24 17:44 ` James Bottomley
2007-11-26 7:54 ` Hannes Reinecke
2007-11-22 10:22 ` 2.6.24-rc3-mm1 Kirill A. Shutemov
2007-11-23 0:18 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-23 0:48 ` 2.6.24-rc3-mm1 Thomas Gleixner
2007-11-23 6:05 ` 2.6.24-rc3-mm1 Kirill A. Shutemov
2007-11-23 8:59 ` 2.6.24-rc3-mm1 Andreas Herrmann
2007-11-23 1:39 ` 2.6.24-rc3-mm1 Gabriel C
2007-11-23 4:12 ` 2.6.24-rc3-mm1 Andrew Morton
2007-11-23 5:55 ` 2.6.24-rc3-mm1 Gabriel C
2007-11-27 6:15 ` 2.6.24-rc3-mm1 Andrew Morton
2007-12-11 16:33 ` 2.6.24-rc3-mm1 James Bottomley
2007-12-12 10:08 ` 2.6.24-rc3-mm1 Boaz Harrosh
2007-12-12 11:03 ` [PATCH] REQ-flags to/from BIO-flags bugfix Boaz Harrosh
2007-12-12 15:18 ` Matthew Wilcox
2007-12-12 15:54 ` Matthew Wilcox
2007-12-13 5:36 ` David Chinner
2007-12-12 16:06 ` Boaz Harrosh
2007-12-12 16:33 ` Matthew Wilcox
2007-12-12 11:36 ` 2.6.24-rc3-mm1 Jens Axboe
2007-12-14 9:00 ` 2.6.24-rc3-mm1 Hannes Reinecke
2007-12-14 14:26 ` 2.6.24-rc3-mm1 James Bottomley
2008-01-07 14:05 ` Multipath failover handling (Was: Re: 2.6.24-rc3-mm1) Hannes Reinecke
2008-01-07 17:57 ` James Bottomley
2008-01-07 18:24 ` Mike Christie
2007-11-26 19:13 ` 2.6.24-rc3-mm1 Randy Dunlap
2007-11-26 19:34 ` 2.6.24-rc3-mm1 Christoph Lameter
2007-11-26 20:40 ` 2.6.24-rc3-mm1 Randy Dunlap
2007-11-26 20:56 ` 2.6.24-rc3-mm1 Christoph Lameter
2007-11-26 20:47 ` [PATCH -mm] x86 allnoconfig memory model Randy Dunlap
2007-11-26 21:00 ` Christoph Lameter
2007-11-26 21:17 ` Randy Dunlap
2007-11-26 21:20 ` Andrew Morton
2007-11-26 21:52 ` Christoph Lameter
2007-11-26 21:57 ` Andrew Morton
2007-11-26 23:19 ` Christoph Lameter
2007-11-27 7:16 ` 2.6.24-rc3-mm1 - brick my Dell Latitude D820 Valdis.Kletnieks
2007-11-27 7:27 ` Andrew Morton
2007-11-27 7:54 ` Valdis.Kletnieks
2007-11-27 8:17 ` Andrew Morton
2007-11-27 10:25 ` Ingo Molnar
2007-11-27 8:25 ` Dave Young
2007-11-27 8:46 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47486D31.3060303@googlemail.com \
--to=nix.or.die@googlemail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=laurent.riffard@free.fr \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).