From: Daniel Lezcano <firstname.lastname@example.org> To: Dinh Nguyen <email@example.com> Cc: firstname.lastname@example.org, email@example.com, Jisheng.Zhang@synaptics.com, firstname.lastname@example.org Subject: Re: [PATCHv2] clocksource: dw_apb_timer_of: add error handling if no clock available Date: Sat, 5 Dec 2020 09:50:29 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 04/12/2020 23:39, Dinh Nguyen wrote: > > > On 12/4/20 2:00 PM, Daniel Lezcano wrote: >> On 04/12/2020 16:36, Dinh Nguyen wrote: >>> commit ("b0fc70ce1f02 arm64: berlin: Select DW_APB_TIMER_OF") added the >>> support for the dw_apb_timer into the arm64 defconfig. However, for some >>> platforms like the Intel Stratix10 and Agilex, the clock manager doesn't >>> get loaded until after the timer driver get loaded. Thus, the driver >>> hits >>> the panic "No clock nor clock-frequency property for" because it cannot >>> properly get the clock. >>> >>> This patch adds the error handling needed for the timer driver so that >>> the kernel can continue booting instead of just hitting the panic. >>> >>> Signed-off-by: Dinh Nguyen <email@example.com> >> >> Did you have time to test the different combinations ? > > I did test both versions and did not see any difference between the two. > On both versions, the kernel was able to continue to boot after trying > to probe the timer driver. Great, thanks! -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-12-05 8:52 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 15:36 Dinh Nguyen 2020-12-04 20:00 ` Daniel Lezcano 2020-12-04 22:39 ` Dinh Nguyen 2020-12-05 8:50 ` Daniel Lezcano [this message] 2020-12-05 10:55 ` Dinh Nguyen 2020-12-05 10:55 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Jisheng.Zhang@synaptics.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCHv2] clocksource: dw_apb_timer_of: add error handling if no clock available' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).