linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	akpm <akpm@linux-foundation.org>,
	"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [PATCH] Declare PNP option parsing functions as __init
Date: Sat, 01 Dec 2007 00:37:26 +0100	[thread overview]
Message-ID: <47509EB6.20300@keyaccess.nl> (raw)
In-Reply-To: <1196442277.23251.318.camel@queen.suse.de>

On 30-11-07 18:04, Thomas Renninger wrote:

> If I have not overseen something, it should be rather obvious that those
> can all be declared __init...
> ---------------
> 
> Declare PNP option parsing functions as __init
> 
> There are three kind of parse functions provided by PNP acpi/bios:
>  - get current resources
>  - set resources
>  - get possible resources
> The first two may be needed later at runtime.
> The possible resource settings should never change dynamically.
> And even if this would make any sense (I doubt it), the current implementation
> only parses possible resource settings at early init time:
>   -> declare all the option parsing __init
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>

Yes. Obviousness aside,

(0) pnpacpi_add_device                          is only caller of
(1)   pnpacpi_parse_resource_option_data        is only caller of
(2)     pnpacpi_option_resource                 is only caller of
(3)       pnpacpi_parse_irq_option
(3)       pnpacpi_parse_dma_option
(3)       pnpacpi_parse_port_option
(3)       pnpacpi_parse_fixed_port_option
(3)       pnpacpi_parse_mem24_option
(3)       pnpacpi_parse_mem32_option
(3)       pnpacpi_parse_fixed_mem32_option
(3)       pnpacpi_parse_address_option
(3)       pnpacpi_parse_ext_irq_option

and

(0) build_devlist                               is only caller of
(1)   insert_device                             is only caller of
(2)     pnpbios_parse_data_stream               is only caller of
(3)       pnpbios_parse_resource_option_data    is only caller of
(4)         pnpbios_parse_mem_option
(4)         pnpbios_parse_mem32_option
(4)         pnpbios_parse_fixed_mem32_option
(4)         pnpbios_parse_irq_option
(4)         pnpbios_parse_dma_option
(4)         pnpbios_parse_port_option
(4)         pnpbios_parse_fixed_port_option

which given that both (0)s are __init already, means all are fine indeed.

Acked-By: Rene Herman <rene.herman@gmail.com>

Rene.


  reply	other threads:[~2007-11-30 23:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 17:04 [PATCH] Declare PNP option parsing functions as __init Thomas Renninger
2007-11-30 23:37 ` Rene Herman [this message]
2007-11-30 23:52   ` Bjorn Helgaas
2007-12-01  0:33     ` Rene Herman
2007-12-02 13:34       ` Thomas Renninger
2007-12-02 13:50         ` Rene Herman
2007-12-02 13:32     ` Thomas Renninger
2007-12-03 11:53     ` Thomas Renninger
2007-12-03 15:52       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47509EB6.20300@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).