From: Jiri Slaby <jirislaby@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <matthew@wil.cx>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: <linux-pm@lists.linux-foundation.org>
Cc: <drzeus@drzeus.cx>
Subject: Re: WARNING: at kernel/resource.c:189 __release_resource
Date: Sat, 01 Dec 2007 13:00:34 +0100 [thread overview]
Message-ID: <47514CE2.3000600@gmail.com> (raw)
In-Reply-To: <47511751.2010707@gmail.com>
On 12/01/2007 09:12 AM, Jiri Slaby wrote:
> On 11/30/2007 11:58 PM, Bjorn Helgaas wrote:
>> On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
>>> On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
>>>> On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
>>>>> On Thu, 29 Nov 2007 16:40:37 -0700
>>>>>> Maybe we could either remove the pnp_{stop,start}_dev() calls
>>>>>> from the suspend/resume path, or move the PNP resource management
>>>>>> out of pnp_{start,stop}_dev().
>>>>>>
>>>>>> Bjorn
>>>>>>
>>>>>> [1] http://lkml.org/lkml/2005/11/30/39
>>>>> So was this particular problem caused/exposed by
>>>>> pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch,
>>>>> or is
>>>>> it in mainline?
>>>> I'm pretty sure this problem is caused by that patch, so we
>>>> we shouldn't see this in mainline.
>>>>
>>>> Jiri, can you try the additional patch below, please?
>>>>
>>>> Index: linux-mm/drivers/pnp/driver.c
>>>> ===================================================================
>>>> --- linux-mm.orig/drivers/pnp/driver.c 2007-11-30
>>>> 13:58:25.000000000 -0700
>>>> +++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.000000000
>>>> -0700
>>>> @@ -161,13 +161,6 @@
>>>> return error;
>>>> }
>>>>
>>>> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
>>>> - pnp_can_disable(pnp_dev)) {
>>>> - error = pnp_stop_dev(pnp_dev);
>>>> - if (error)
>>>> - return error;
>>>> - }
>>>> -
>>>> if (pnp_dev->protocol && pnp_dev->protocol->suspend)
>>>> pnp_dev->protocol->suspend(pnp_dev, state);
>>>> return 0;
>>>> @@ -185,12 +178,6 @@
>>>> if (pnp_dev->protocol && pnp_dev->protocol->resume)
>>>> pnp_dev->protocol->resume(pnp_dev);
>>>>
>>>> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
>>>> - error = pnp_start_dev(pnp_dev);
>>>> - if (error)
>>>> - return error;
>>>> - }
>>>> -
>>>> if (pnp_drv->resume)
>>>> return pnp_drv->resume(pnp_dev);
>>>>
>>> No, it breaks suspend.
>> Thanks for trying it. What are the symptoms? I'd like to understand
>> why we need to stop the devices before suspend.
>
> Ho hum, it's not so easy, it's kind of nondeterministic now. Maybe
> some other
> issue. If I remove 8250* modules from the kernel, it works. Otherwise
> it locks
> in the middle of suspend after disks and graphics go down no matter if
> the patch
> has been applied or not. Trying to investigate this further...
I didn't get it. Maybe some trolls poking around or something (maybe the
ext3 breakage which fsck fixed). It works after recompilation of the
whole tree. And the important part -- the warning has gone. Just a note,
fold this -fix into it:
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index f5b64ee..b0fc3ee 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -170,7 +170,6 @@ static int pnp_bus_resume(struct device *dev)
{
struct pnp_dev *pnp_dev = to_pnp_dev(dev);
struct pnp_driver *pnp_drv = pnp_dev->driver;
- int error;
if (!pnp_drv)
return 0;
next prev parent reply other threads:[~2007-12-01 12:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 21:41 WARNING: at kernel/resource.c:189 __release_resource Jiri Slaby
2007-11-27 6:05 ` Andrew Morton
2007-11-27 12:38 ` Matthew Wilcox
2007-11-29 23:40 ` Bjorn Helgaas
2007-11-30 0:42 ` Andrew Morton
2007-11-30 21:08 ` Bjorn Helgaas
2007-11-30 22:49 ` Jiri Slaby
2007-11-30 22:58 ` Bjorn Helgaas
2007-12-01 8:12 ` Jiri Slaby
2007-12-01 12:00 ` Jiri Slaby [this message]
2007-12-05 18:24 ` RFC: PNP: do not stop/start devices in suspend/resume path Bjorn Helgaas
2007-12-05 18:50 ` Matthew Wilcox
2007-12-06 1:07 ` Rafael J. Wysocki
2007-12-06 23:25 ` Bjorn Helgaas
2007-12-12 8:16 ` Andrew Morton
2007-12-12 16:29 ` Bjorn Helgaas
2007-12-13 8:26 ` Pierre Ossman
2007-12-07 7:13 ` RFC: " Shaohua Li
2007-12-10 23:26 ` Bjorn Helgaas
2007-12-24 1:43 ` do not stop/start devices in suspend/resume path: the SCSI case Stephane Ascoet
2007-12-24 3:21 ` Bjorn Helgaas
2007-12-01 21:01 ` WARNING: at kernel/resource.c:189 __release_resource Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47514CE2.3000600@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).