From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Joel Fernandes <joelaf@google.com>
Cc: rostedt <rostedt@goodmis.org>,
"Joel Fernandes, Google" <joel@joelfernandes.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Kees Cook <keescook@chromium.org>, Jessica Yu <jeyu@kernel.org>,
kernel-hardening <kernel-hardening@lists.openwall.com>,
kernel-team <kernel-team@android.com>, rcu <rcu@vger.kernel.org>
Subject: Re: [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init
Date: Wed, 10 Apr 2019 00:20:49 -0400 (EDT) [thread overview]
Message-ID: <475423743.2834.1554870049461.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CAJWu+orXgFkJpB8ww9kz_Nzmmj4qXjj2HtN_eDW3x+XPLbH0qw@mail.gmail.com>
----- On Apr 9, 2019, at 11:38 PM, Joel Fernandes joelaf@google.com wrote:
> On Tue, Apr 9, 2019 at 10:48 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> On Tue, 9 Apr 2019 22:41:03 -0400
>> Joel Fernandes <joel@joelfernandes.org> wrote:
>>
>> > > Other than that, the two patches look fine to me.
>> >
>> > Could I add your Reviewed-by in the respin?
>>
>> You can add an Acked-by, as I haven't spent enough time to offer a
>> Reviewed-by tag. ;-)
>>
>> Maybe I'll get some time to vet it a bit more tomorrow, and then
>> upgrade the ack to a review.
>>
>> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>
>
> Thanks!
>
> Also we could possibly consider adding the tracepoint ptrs array as
> well to the list, which would be useful I think, if one were to over
> write that array by accident (and the bpf tps related array too).
Yes, please!
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-04-10 4:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 1:14 [PATCH 1/2] module: Prepare for addition of new ro_after_init sections Joel Fernandes (Google)
2019-04-10 1:14 ` [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init Joel Fernandes (Google)
2019-04-10 1:17 ` Joel Fernandes
2019-04-10 2:38 ` Steven Rostedt
2019-04-10 2:41 ` Joel Fernandes
2019-04-10 2:48 ` Steven Rostedt
2019-04-10 3:38 ` Joel Fernandes
2019-04-10 4:20 ` Mathieu Desnoyers [this message]
2019-04-10 16:26 ` [PATCH 1/2] module: Prepare for addition of new ro_after_init sections Kees Cook
2019-04-10 17:48 ` Joel Fernandes
2019-04-10 18:21 ` Kees Cook
2019-04-10 18:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475423743.2834.1554870049461.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=jeyu@kernel.org \
--cc=joel@joelfernandes.org \
--cc=joelaf@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).