linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
Date: Tue, 04 Dec 2007 14:58:17 +0300	[thread overview]
Message-ID: <475540D9.9010109@openvz.org> (raw)
In-Reply-To: <20071204034836.47211436.akpm@linux-foundation.org>

[snip]

>> We do have some current code in the network stack that fails miserably
>> when  register_sysctl_table returns NULL, and there are explicit
>> checks for that.
> 
> So that code would be failing today with CONFIG_SYSCTL=n?  Unless the
> failing code is itself under #ifdef CONFIG_SYSCTL, in which case we don't
> need to change anything?

Exactly! If the code checks for the return value it won't work
with CONFIG_SYSCTL=n, if it dies not - it may happily use the
sysctl stub and avoid extra ifdefs.

But this difference looks clumsy :(

Thanks,
Pavel

  reply	other threads:[~2007-12-04 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 12:58 [PATCH 0/7] Start using sysctl paths in the core kernel code Pavel Emelyanov
2007-11-30 13:02 ` [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL Pavel Emelyanov
2007-12-03 21:38   ` Andrew Morton
2007-12-03 23:32     ` Eric W. Biederman
2007-12-04  8:58     ` Pavel Emelyanov
2007-12-04  9:23       ` Andrew Morton
2007-12-04  9:31         ` Pavel Emelyanov
2007-12-04  9:45           ` Andrew Morton
2007-12-04 11:40             ` Eric W. Biederman
2007-12-04 11:48               ` Andrew Morton
2007-12-04 11:58                 ` Pavel Emelyanov [this message]
2007-12-04 12:48                   ` Eric W. Biederman
2007-11-30 13:04 ` [PATCH 2/7][QUOTA] Use sysctl paths to register tables Pavel Emelyanov
2007-11-30 13:09 ` [PATCH 3/7][SYSVIPC] Use the ctl " Pavel Emelyanov
2007-11-30 13:11 ` [PATCH 4/7][SCHED] " Pavel Emelyanov
2007-11-30 13:13 ` [PATCH 5/7][UTS] " Pavel Emelyanov
2007-11-30 13:16 ` [PATCH 6/7][MQUEUE] Move sysctl management code under ifdef CONFIG_SYSCTL Pavel Emelyanov
2007-11-30 13:18 ` [PATCH 7/7][MQUEUE] Use the ctl paths to register tables Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475540D9.9010109@openvz.org \
    --to=xemul@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).