Alan Cox a écrit : >> No matter what you consider as being better, changing a 12 years old and >> widely used userspace interface like /dev/urandom is simply not an >> option. >> > > Fixing it to be more efficient in its use of entropy and also fixing the > fact its not actually a good random number source would be worth looking > at however. > Yes, since current behavior on network irq is very pessimistic. If you have some trafic, (ie more than HZ/2 interrupts per second), then add_timer_randomness() feeds some entropy but gives no credit (calling credit_entropy_store() with nbits=0) This is because we take into account only the jiffies difference, and not the get_cycles() that should give us more entropy on most plaforms. In this patch, I suggest that we feed only one u32 word of entropy, combination of the previous distinct words (with some of them being constant or so), so that the nbits estimation is less pessimistic, but also to avoid injecting false entropy. Signed-off-by: Eric Dumazet