From: Tejun Heo <htejun@gmail.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: sam@ravnborg.org, Linux Kernel <linux-kernel@vger.kernel.org>,
notting@redhat.com, rusty@rustcorp.com.au, kay.sievers@vrfy.org,
greg@kroah.com
Subject: Re: [PATCH] kbuild: implement modules.order
Date: Wed, 05 Dec 2007 16:11:49 +0900 [thread overview]
Message-ID: <47564F35.30706@gmail.com> (raw)
In-Reply-To: <20071205070127.GG2460@hacking>
WANG Cong wrote:
>>> I think, you forgot to free(3) the memory you calloc(3)'ed and
>>> malloc(3)'ed above.
>> It's a simple program where whole body is in main(). Why bother?
>> What's the benefit of adding hash-table iterating free logic?
>>
>
> Personally, I think memory leaks are bugs. And we hate bugs. ;)
Trust me. As a person buried alive in bug reports, I hate bugs too. I
just don't agree that this type of programs should free all its
resources before exiting. How about adding a comment saying /* we're
going out anyway, don't bother freeing hashtable */?
--
tejun
next prev parent reply other threads:[~2007-12-05 7:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 13:49 [PATCH] kbuild: implement modules.order Tejun Heo
2007-12-04 13:55 ` [PATCH] depmod: sort output according to modules.order Tejun Heo
2007-12-05 7:25 ` Sam Ravnborg
2007-12-05 7:33 ` Tejun Heo
2007-12-05 7:34 ` Tejun Heo
2007-12-05 19:06 ` Sam Ravnborg
2007-12-05 23:28 ` Tejun Heo
2007-12-06 22:37 ` Sam Ravnborg
2007-12-07 0:59 ` Tejun Heo
2007-12-07 5:14 ` Sam Ravnborg
2007-12-08 8:09 ` Jon Masters
2007-12-08 12:39 ` Alan Cox
2007-12-08 8:03 ` Jon Masters
2007-12-08 8:19 ` Jon Masters
2007-12-09 5:48 ` Tejun Heo
2007-12-04 15:07 ` [PATCH] kbuild: implement modules.order WANG Cong
2007-12-04 15:21 ` Tejun Heo
2007-12-05 7:01 ` WANG Cong
2007-12-05 7:11 ` Tejun Heo [this message]
2007-12-05 7:22 ` Li Zefan
2007-12-06 3:02 ` Rusty Russell
2007-12-07 17:48 ` Adrian Bunk
2007-12-07 23:59 ` Tejun Heo
2007-12-08 14:28 ` Adrian Bunk
2007-12-09 5:44 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47564F35.30706@gmail.com \
--to=htejun@gmail.com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notting@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).