archive mirror
 help / color / mirror / Atom feed
From: Aaron Carroll <>
To: Jens Axboe <>
	Peter Chubb <>
Subject: [PATCH] as-iosched: fix incorrect comments
Date: Wed, 05 Dec 2007 21:06:50 +1100	[thread overview]
Message-ID: <> (raw)

Two comments refer to deadlines applying to reads only.  This is
not the case.

Signed-off-by: Aaron Carroll <>
 block/as-iosched.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/as-iosched.c b/block/as-iosched.c
index dc715a5..4513fc5 100644
--- a/block/as-iosched.c
+++ b/block/as-iosched.c
@@ -880,7 +880,7 @@ static void as_remove_queued_request(struct request_queue *q,
- * as_fifo_expired returns 0 if there are no expired reads on the fifo,
+ * as_fifo_expired returns 0 if there are no expired requests on the fifo,
  * 1 otherwise.  It is ratelimited so that we only perform the check once per
  * `fifo_expire' interval.  Otherwise a large number of expired requests
  * would create a hopeless seekstorm.
@@ -1159,7 +1159,7 @@ static void as_add_request(struct request_queue *q, struct request *rq)
 	as_add_rq_rb(ad, rq);
-	 * set expire time (only used for reads) and add to fifo list
+	 * set expire time and add to fifo list
 	rq_set_fifo_time(rq, jiffies + ad->fifo_expire[data_dir]);
 	list_add_tail(&rq->queuelist, &ad->fifo_list[data_dir]);

             reply	other threads:[~2007-12-05 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 10:06 Aaron Carroll [this message]
2007-12-05 10:11 ` [PATCH] as-iosched: fix incorrect comments Nick Piggin
2007-12-05 10:16   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).