linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Anderson <anderson@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: allow > 2GB executables to run on 64-bit systems
Date: Wed, 05 Dec 2007 14:58:31 -0500	[thread overview]
Message-ID: <475702E7.1000607@redhat.com> (raw)
In-Reply-To: <p73fxyhj5f7.fsf@bingen.suse.de>

Andi Kleen wrote:
> Dave Anderson <anderson@redhat.com> writes:
> 
> 
>>When a executable that is greater than 2GB in size is attempted on a 64-bit
>>system on a file system that calls, or uses generic_file_open() as its
>>open handler, it fails with an EOVERFLOW erro.  This patch adds a call
>>to force_o_largefile() call in open_exec(), as done in sys_open() and
>>sys_openat().
> 
> 
> Wouldn't it be better to just always pass O_LARGEFILE unconditionally
> there? e.g. in theory a 2.5GB executable should work on i386 and binfmt_*
> shouldn't have any problems with a large file.
> That would simplify your patch.
> 
> -Andi
> 

I agree in theory.  We've only seen instances on 64-bitters...

Dave


  reply	other threads:[~2007-12-05 19:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 15:36 [PATCH] exec: allow > 2GB executables to run on 64-bit systems Dave Anderson
2007-12-05 19:41 ` Andi Kleen
2007-12-05 19:58   ` Dave Anderson [this message]
2007-12-05 19:56     ` Andi Kleen
2007-12-05 20:33       ` Dave Anderson
2007-12-06 22:15         ` [NEW-PATCH] " Andi Kleen
2007-12-06 22:37           ` Dave Anderson
2007-12-06 22:40             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475702E7.1000607@redhat.com \
    --to=anderson@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).