From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Victor <linux@maxim.org.za>,
Patrice VILCHEZ <patrice.vilchez@atmel.com>,
ARM Linux Mailing List <linux-arm-kernel@lists.arm.linux.org.uk>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] usb: at91_udc: correct hanging while disconnecting usb cable
Date: Thu, 06 Dec 2007 12:07:31 +0100 [thread overview]
Message-ID: <4757D7F3.8040904@atmel.com> (raw)
Correct hanging while disconnecting the USB device
cable. Prevent a race between vbus and UDP interrupts.
This bug was tracked on at91sam9260ek boards.
Signed-off-by: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
---
A usb resume interrupt was firing after the vbus
interrupt : the IP was then already stoped and not able
to deal with it (no more clock). A simple interrupt disabling
is ok as the "end of bus reset" irq is non maskable and ok
to resume the USB device IP.
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -908,6 +908,7 @@ static void pullup(struct at91_udc *udc,
if (is_on) {
clk_on(udc);
+ at91_udp_write(udc, AT91_UDP_ICR, AT91_UDP_RXRSM);
at91_udp_write(udc, AT91_UDP_TXVC, 0);
if (cpu_is_at91rm9200())
at91_set_gpio_value(udc->board.pullup_pin, 1);
@@ -925,6 +926,7 @@ static void pullup(struct at91_udc *udc,
}
} else {
stop_activity(udc);
+ at91_udp_write(udc, AT91_UDP_IDR, AT91_UDP_RXRSM);
at91_udp_write(udc, AT91_UDP_TXVC, AT91_UDP_TXVC_TXVDIS);
if (cpu_is_at91rm9200())
at91_set_gpio_value(udc->board.pullup_pin, 0);
next reply other threads:[~2007-12-06 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 11:07 Nicolas Ferre [this message]
2007-12-06 16:02 ` [PATCH] usb: at91_udc: correct hanging while disconnecting usb cable David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4757D7F3.8040904@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=david-b@pacbell.net \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=patrice.vilchez@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).