From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030395AbcGKIAe (ORCPT ); Mon, 11 Jul 2016 04:00:34 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:50806 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030318AbcGKIAc (ORCPT ); Mon, 11 Jul 2016 04:00:32 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 Date: Mon, 11 Jul 2016 10:03:25 +0200 Message-ID: <4765191.NGpMC1JR46@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468135649-19980-7-git-send-email-vw@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-7-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:v9dsCxLgI6haiLRybfZwNm7VNgAkENGevS9QF86v153CtJb9Qx/ P/QTPjBsNLEh64yuXuda71IB+Rzp/hVALL4QmWJqLtWMrg6ND8S17YwDWAVyjZBvgwzO7rp JdJpwZrZqA+CVC4FSI8XPBzpx+uzvm1A3Zbh86cYZmbnfAX55W99jxpDHHn3uKJCrmK4CmR JVoXtr9U5qsMAI51Beg+Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:XpxUF4f3beE=:l7quRK0gxpfvnE2a4VfBLM bm3XxGJIh6zEypUsJxvpnOI40T8nE/bd13f7BWxpzhL4GHX/jFahRSL/PUwVR49qeCNXlEtzQ FgoyW+tsw1PWP87Hn88M5CMji+3SfVvZ2DVjtDiR6420L/T6lSVa3qydnNGnrjws2xy37AJ/L lGxr+WjkezoXYKrjQfC8bEf1FGL9qe1ALWAn6oX+zc3IEJm4jrd67leY8+Jq95pKou9TtwZBL 0vp5XF+jzLkpXsJgQwWkQChiSnFElq8XYHbW3htn3byOpzVIj1NVfIn54uv6UTYuE27R173Bi qk5AkUyA3SBF5JSWb/cHvPW4HlEkBfxxLnjFyZXpGPWFCBvpIFYF29b9GxcHyPpCSLX3IVBI0 5tAF5MTlr3SjPVFSeyJxQ0SwneLsDuy/hVLFPe/O5c64AYCd0BK1SuyihzOgatk/egGsbevrN L89mMcO6nK/3biCfNFzQNlByfQ6ZtFVIKKAPTKKR3qacFiowW2JWZgMq4ECQSMFI39RUb0r4G tR1XDARCcILvB93C9Ou2LG6QTMlOWjHHQX4rXu2v7gDWJ7FrouUMprCi+OSMjgZUnGYaE0J7G dvd3LIXlg2sr2MMLekvSvXSE70dfGhHZOhYr1cvldrZHo1B9zSObYKSSbtFZcma95adHVqryU AqIMf3Cjqk0Lit0Lk0dzW/BfrOXvVlJ+UjL+NFiQF/Qy6l+NYSdffnSic0NyVSekxXv74VvM/ B7dzU6ox0jqCVVAj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); > + if (ret) > return -EINVAL; > + > + soc_dev_attr->machine = "NUC900EVB"; > + soc_dev_attr->family = "NUC900"; > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + kfree(soc_dev_attr); > + return -ENODEV; > + } > + > + ret = regmap_read(syscon_regmap, GCR_CHIPID, &nuc900_chipid); > + if (ret) > + return -ENODEV; > + > + device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > + device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > + > + dev_info(&pdev->dev, "Nuvoton Chip ID: 0x%x, Version ID:0x%x\n", > + nuc900_chipid & GCR_CHIPID_MASK, > + (nuc900_chipid >> 24) & 0xff); I'm still a bit unsure about the set of attributes here. - The "soc_id" is read from the device tree from the field that contains the board name, I think for consistency you should try to map the GCR_CHIPID to the name of the SoC and assign that here - The "machine" is hardcoded to "NUC900EVB", which in turn looks like a particular board but not the one you are running on. Maybe read that from the DT instead? - The "revision" is not filled at all, I would suggest using something derived from the GCR_CHIPID register here - you have two nonstandard attributes "chipid" and "version", which I'd hope to avoid -- the set of standard attributes is supposed to give enough information about the machine, and platform independent user space will never read those. Arnd