From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932928AbcLMTDr (ORCPT ); Tue, 13 Dec 2016 14:03:47 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:49259 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbcLMTDo (ORCPT ); Tue, 13 Dec 2016 14:03:44 -0500 Subject: Re: [PATCH] btrfs: limit async_work allocation and worker func duration To: Maxim Patlasov , References: <148072986343.13061.16191252239168261528.stgit@maxim-thinkpad> <20161212145443.GT12522@twin.jikos.cz> <2d4aaf16-b9b3-6cd9-d542-c74f00811c93@virtuozzo.com> CC: , , From: Chris Mason Message-ID: <47667065-cf42-50b7-2862-d270628dc8f8@fb.com> Date: Tue, 13 Dec 2016 14:03:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <2d4aaf16-b9b3-6cd9-d542-c74f00811c93@virtuozzo.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.101.197.43] X-ClientProxiedBy: CY4PR16CA0034.namprd16.prod.outlook.com (10.171.216.21) To MWHPR15MB1248.namprd15.prod.outlook.com (10.175.3.10) X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;2:VhHUs2mTIbCwdIELt5VzvFbJsk+m/r6gCPrhenKi0e72g2EMOVKTXc8l9zFA1o4X2CQt6btdWtLao8eCT6Pjd1a25RFzkLZ+fA4Yt2GWWvcPDDSjy+xRyqxspPOnK14WbwX5qsWTpbe+GHj8hbJK6EoMVTL5ivAAK9qeKFmbNpk=;3:e6hWUEXc+2lWc4Afbu9AwyODRQrs2aILfdZfEnmDil2NB+81KorsXzwxJc6q6XmGPVDQCOhMeCG4rIlAlHYEprUqaIW/OEWTA6UkQ7wF9R8OEFEyZOfnzGJBbAx3hYwVnGeyJHeDY8LRxksZs4GrCPlkVrH+gfRjqskHekoqg1o= X-MS-Office365-Filtering-Correlation-Id: 0c22b17f-dd8c-40ee-280e-08d4238abd78 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1248; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;25:6iUtZ7cn7YC3BkfJcnqx1Wp3bW7YsHtIqaiw3laBaB0viY50Dj3Gq0SDeBtR5pBLn9MU+5h5pSxzWXOv8FLeNldlmvVVNC6BiyE/GtO7wtpHf5rHVoSv+b5ZYeIEgs/6ifHo2AW5ArlxTNQwM17wVdlMV5mjvF1VllsPmRC7S5Rh+WSmMvzhQxvWEauFFYySliQ4bhrWqESaBzKD+HqWXS3oKZbryr9NA2AENs2xq3//xAXcbpXg71hIwcIu/2O/DviCL7lVstM6FWpXd8L4m6hhUBWePE7/g8wJ8b/WxUs+TyaaBsN5uhH2ITuZnAmFkM84wS3HNxGMbvyV29OybuqUyPBczFtGpe4UefTapqOT5X7BA8aHRRktaoOCi+JZAzTpJiREJI79YZl53+K44XuQZpxR9pu4xwkHi01yCNhwetJ1ioqU1eugGWF8FIOhsjWlrPJbDMen3QsJ/27BAO6Td0qzP6Eyg9LjXtfOhzHXjG0FkF7N98oKxnMuVnS2j2isfc6G2lGnvMVatb26iKTLz2pEz09PqcbMrKkdI6AQFkUFFB6KabQIdBU3P4ChszGrE73g7TH3q3jV9GkZ0nlAvfKKrNbVtfVmXeLwMvHF+wXA8A++6BhcUSXt0FcsNq5OQhE3THjLWTBJymVwMAr6YepLiJIke8TDrou+Jk55WzZeDp1hGaNOgEzFk9Zi9WdWKq2Pc9AuPk1ubnBVqXprvC+2FKqE91/BoeLGzWNRDyGM5H4pN9Uz/KRaw4W0 X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;31:v0gUXTElmqgmAtZHrWPhFpplnoawD/+AKL+xhGvB3F7gJrXeYwMh1rdDNW2DUrxYgwQFVFWMYcKp4wzhHL2lsZ8mJpK8VqF/BNv5SveJcWZYHueCratXpjgJ4rlPkE54PnOMRWWWm5A2NKzYTN7/xeo0BK31u/1cNB9I36wTX06EUPxTefSbnd0HieRFSEQF1dEO2ZKrcIjD9Yyu+i3v/bJXYBDWEwT52t/2LzaAum04BMINNvd8Yl0KhTIupwOrdeNeVe2Rmbd2BoeJ+pMpFA==;20:+ziYZWBTuupeLmWhpMEPMjiF5AXZt0YJLiynZxRj1Rmj+/pAyPMu+n6s9BCjrB3i4TWojaAZ0zBVabFnO85XPaPOO/6wDRpKiYmSoNvF/VXTK8z4il5NKv34iz2bb/iMUACOw4PfhYw9bcDDnjJ4OuyaEYPYqNqEXZg59EU+cM5n2CF6Ak9MC+9MMBfAWpPQn0YODkhtkaSDgXYO2U7A2QchPtYxojX3r2uLe1jeulkLT9fN7WsPCX05YbAwiHA6hFRXzw0ShqyZYpP+4FENRQNhTbVT3cjh+etB7SBnO2VnZiqPbRC79LfjFM9LIXr/VJ4MBzTNMIMn6G6nZDSb9IT35AFXBLlXMkkAJTSa1om74DNgibnFu63upvcHxB9twTkR0TCI5bykbFO6sXEWC53KJboddy2anYHyxbfp2/jysKIu305XRHe401NnUO8dJABl2xBuFbrTkVWka/qQBs1fsbAzUQFYIbK/LCI4TwMI26PXSiOJ4w48rCn8gYVt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148);SRVR:MWHPR15MB1248;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1248; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;4:h1i4foLMyA0XoGnM/0lLg2DBY5563WDFySqpgVMQHsKyfFuW/cwikstQuthD/B7nFxHce/0F20SGx+xbrGzH0d/eTKbdJSqPRdpbYHPgs+HmVOvFGO/RLUCC4Cw6WMe6ldcTMiffCCDrEpN+lSEOmbW8TOr/Iuc8RHMnL6KjbyN0g3Uub6gIc6gCYg75T8LzGjYqWx5Cs2Zzaepu7TjI2zKtYWawlam1SDQFzfgIUa3LTxT0Y/lgbzo1rMh7PJYsENLocYVBAo843sbI9sVhU194JveK0XwotfxBXAqxwPS2UQ3Aw1W9OYogkYrr+jVPuMqg9S5ZjEY6sY6kpad01J6R01DQgNOsehNotcZjhe75KHBC3+yD+aAeysH56aPoYD4EY17Tiq+Bq56cN9HI4EqERHTWpL2d7mDEgsSe4q3htmj1Tt7MCbHfNJRmt4BygBkHBcFhX9y3+J4ZnvxBCHumkiuuw6RAD9XWP1iQJjTJWQ0Lv+cBHTdJn6IgTLPVH7bGvxWr2ki6h8z9jQTJ4HaRa1Lw3F6xeoH/KXdQXyMbzousu6yfKAlHHBgIziU+ X-Forefront-PRVS: 01559F388D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6049001)(6009001)(7916002)(39450400003)(39850400002)(39840400002)(39410400002)(199003)(24454002)(189002)(377454003)(68736007)(229853002)(81166006)(2950100002)(65956001)(6486002)(8676002)(77096006)(66066001)(189998001)(65806001)(86362001)(47776003)(4001350100001)(5001770100001)(106356001)(54356999)(31686004)(90366009)(38730400001)(230700001)(6666003)(117156001)(33646002)(64126003)(36756003)(5660300001)(81156014)(50986999)(101416001)(7736002)(23746002)(97736004)(3846002)(4326007)(2906002)(305945005)(50466002)(42186005)(6116002)(92566002)(76176999)(105586002)(65826007)(83506001)(31696002)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1248;H:[192.168.1.14];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1248;23:xS2VtvaVZ2TSWNPgmXRuNdHBB5epda/aCr+Ti?= =?Windows-1252?Q?c6YpIhkRhS2JdC4yvmZ6oWDdgEFKw7aE469BmKVOUtTBrfdqsYoOuHrx?= =?Windows-1252?Q?8DJlz5VNPBSeesgmoHlei8K+ZL6mO0r/w4auv7b2v0/y5x8eCXNiDrTJ?= =?Windows-1252?Q?Aek7t+wx6MVWfDtV6WlaJWW9q+p7oRsh/xmkysTYMp1kZvzZDqj7aP2Z?= =?Windows-1252?Q?59l7fC5OMOmCA2W4UdPgdBeD6uojfRuU4LtQrpdYHfMI+3AXGcGYUJDI?= =?Windows-1252?Q?FqAxn/igV+XhiduwCVWhBBKjsYgJDvLEygsIMkQ4MaOKDWgL4m6Aqfib?= =?Windows-1252?Q?ZVnVTPafHejrEw5d45VOKLHgYKwz7xyhyD7S6ULYMPOT/MjX9BoBXTQH?= =?Windows-1252?Q?mFDD2r03MzmbtOr1Xn5cVOhVvN5MP3LQvLjxaXDLFtrT1tp9tBs5blS4?= =?Windows-1252?Q?dWmkt3qpGqlSkLMFZqvhT6WXoba81J9bYpG2YdI+jxT4JAiBA1tc3r+U?= =?Windows-1252?Q?6o5rylKsWAPWEN586XgSXh1e9hXLUO8BvCVlxutOJu4Voet7Akyt4hyM?= =?Windows-1252?Q?T26tfUAKSJId4J2tPoETjFLjCC0q9dwvz5bKPpCCnkT9cqIO74MZlqNP?= =?Windows-1252?Q?+sKLURAdbQg6tuYPcCzXxMCuoF1Ih/64detYJC/jEZ69ZxJ049HLMZCR?= =?Windows-1252?Q?xJCtkME5aXNWI945xumYclEvS83OewjdMERYGR+XOyXTQv/qGkbxuZ+M?= =?Windows-1252?Q?qqu35W4IGE+LXZBdboPYPJes0cC8ateY05sHkuSiUJ1R5GwehoXmDKvm?= =?Windows-1252?Q?NxSVMC+4Az0z6YlJ3lr0suNyhyrTYmwdJv8x1+vyklS8whURUDmmORh7?= =?Windows-1252?Q?mrpHn61+EfODH1ev9M1j+eSBa031aAI4KtSj7k1dKap+Xey2N/cXpsAS?= =?Windows-1252?Q?c5w8JR6+R3xLTLQLBli0aXXItVPEI3V2RNSz6xA7AweWQZ4wNP40KGFc?= =?Windows-1252?Q?BXAqxAEJ5oklIBbW35vTMQJx4Jb2aIkcg9BMtxlhTPmvUXPxyfKWs3TJ?= =?Windows-1252?Q?JgzZWLfLsqQSLmJZTF33kydMFvM+Qg/E/4qkySZUhakOOB+zF93+yJmQ?= =?Windows-1252?Q?osZ0pKMVVkJ5vW/QV04n3gjEkhAdJn44iZ0V811o3EcqG4L9hCDwOoVS?= =?Windows-1252?Q?7HyGLzlQoIllQqRdSzgK+Q9U32VIzhBY+3vWvnrD8VCCVwqX4DIf24h/?= =?Windows-1252?Q?aVvE9bMzRFH7Xgktn01bYZGzEvLHpQ1GY1JK2IqCfj6uNXRqsX5S/haJ?= =?Windows-1252?Q?W8gvb3s+e/4k0Y53g56F7txMwChIAE444izj1wCZ663ptfrcQJ+t/ufq?= =?Windows-1252?Q?T2heYs7Usf2Tc6HeO5TYCFk2jqtLN4GMA+V1QVq7/JEk+3HBTAul5AyH?= =?Windows-1252?Q?extmXjyVPd3Da4clI/Zek3bYD2jWQ0omQvNgiyekT0c+RE/lwhB/ZFGg?= =?Windows-1252?Q?3UFDl/OzXpqJtWn1L+Bm56oGn1rw7O4h7kCB/DV6cwPl5zgMGXiZGGpQ?= =?Windows-1252?Q?1yV8w1AxfXb9grGbEpO2oNwucWwdIz3bvoCsaAk77zom1okAGDKu0b/e?= =?Windows-1252?Q?1lnVjuBhNSKtL/wRgbugnFRV2kml/iHg9VospLEDIah8kwSGGNUDucr0?= =?Windows-1252?Q?ADipbHSpMpVVjU3/aNvDoi/X3qhkuE=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;6:0uVTQOWuVOrGuw+fdGYWfJJUdgQlTFUazzfXWJI1hmCt71g5+UfWWIVtISDHuiXmCI4Ayuq4HjF0t0UESN4ER+WLBpRn3o4yXlo0v76HQXztI5bi/NLKTox8gPW79g8br9EorVB6gBhK986DTLVZCDEhWeOKkzb/q2FfBpoRoY/IGDM63kweV+sE6M7H+2bbiIgCKvrAW1xgGzwZk3sX2LGKPBWSgCrNt+adLM0PNTkCfuqP7Oysgv9wXbhzONHhzljRPOnQPgMBHm+ktsR4Sdou/7k0c2jScvHR0iO/mMzrRXmst+6Pz22owgbJmXQR;5:l4U+B1Zzwf/F78ax40EVAFLlCHPs5Pzx9bYPfBUw/7eDHGeeCtDjGg+mbsQFvj+FNGGxfpSblXEZtSp8sCfoG1BBqUZ8phOk2GTmP/i8Z1raDpw3Yk37LMo2D0GH7LafMBMPRbPSO2kmdHKrI1c8NA==;24:7BNOnhGuPfEPMgSm2w5mJALa408+Oi9mifr/dZi4YojRO/0QwonskEfF3K5wNP+gEGpoOqPRG74M3Xs8OHLk5R6DxBsJ/Gi61PGEH7rM4DI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1248;7:Q/ewdQI1Ksit3P/Ut/cVI6MQMEDe2bA5cun/Uv944Bgpog1egoNTXhgFoB61DHQkwhCuMv9npzqr69uxCr4RF9vlDxXDlk8YUwgqeJ/z3BUzxGBA25W37bh6MtXs9wkJyPyEuO7K/ab8itFJIj7Z08hR8Q7FH2rA2zO8c9+ea9cC0NFjEPhc8RBCnkJwojsUTgCOiegV2DLKEfAUpn1bEGPqSAGiHL++arzLksR/UEZ5cxrqnBUu/NKxLVJ7O96D4OJxsKk1XuwSiIIKVUC1Uj/culct2RK4R4nOrYF2oPyIDUVy20RflY6SnSr44usFJnOk7MKPO7xMuXAfyoPUmqDXe9q8VNvWNdvRvImHFXY=;20:eZm0uT6voCAx4CIb5Mr8hV4GsAhSfKmvV1rvsogCXrK5iNYed06tuwcQt8n1eAagmUpXkfOX5hPxB6dL17LdPexQJ292TI/XdZdqHNSJvTQsbGVj+/l4o4NMJOdGkXCd1V2d/RORgWk+RZZW0xXJaAxiwYRHHcLJKpSwpTkvunc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2016 19:03:35.1004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1248 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-13_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2016 03:35 PM, Maxim Patlasov wrote: > On 12/12/2016 06:54 AM, David Sterba wrote: > > As far as we don't have any NO_THRESHOLD users of > btrfs_workqueue_normal_congested for now, I tend to think it's better to > add a descriptive comment and simply return "false" from > btrfs_workqueue_normal_congested rather than trying to address some > future needs now. See please v2 of the patch. > Thanks, I've got v2 and added a cc for stable to v3.15+, which isn't exactly right, but its when the new workqueue system was put in place. -chris