From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385E7C18E5A for ; Wed, 11 Mar 2020 15:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B775206C0 for ; Wed, 11 Mar 2020 15:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729905AbgCKPL1 (ORCPT ); Wed, 11 Mar 2020 11:11:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:41172 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729521AbgCKPL0 (ORCPT ); Wed, 11 Mar 2020 11:11:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 59B93ACA1; Wed, 11 Mar 2020 15:11:24 +0000 (UTC) Message-ID: <47735babf2f02ce85e9201df403bf3e1ec5579d6.camel@suse.com> Subject: Re: disk revalidation updates and OOM From: Martin Wilck To: He Zhe , Christoph Hellwig , jack@suse.cz, Jens Axboe , viro@zeniv.linux.org.uk, bvanassche@acm.org, keith.busch@intel.com, tglx@linutronix.de, yuyufen@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 Mar 2020 16:11:28 +0100 In-Reply-To: <209f06496c1ef56b52b0ec67c503838e402c8911.camel@suse.com> References: <93b395e6-5c3f-0157-9572-af0f9094dbd7@windriver.com> <209f06496c1ef56b52b0ec67c503838e402c8911.camel@suse.com> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-03-11 at 11:29 +0100, Martin Wilck wrote: > On Mon, 2020-03-02 at 11:55 +0800, He Zhe wrote: > > Hi, > > > > Since the following commit > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.5/disk-revalidate&id=6917d0689993f46d97d40dd66c601d0fd5b1dbdd > > until now(v5.6-rc4), > > > > If we start udisksd service of systemd(v244), systemd-udevd will > > scan > > /dev/hdc > > (the cdrom device created by default in qemu(v4.2.0)). systemd- > > udevd > > will > > endlessly run and cause OOM. > > I've tried to reproduce this, but so far I haven't been able to. > Perhaps because the distro 5.5.7 kernel I've tried (which contains > the > offending commit 142fe8f) has no IDE support - the qemu IDE CD shows > up > as sr0, with the ata_piix driver. I have systemd-udevd 244. Enabling > udisksd makes no difference, the system runs stably. ISO images can > be "ejected" and loaded, single uevents are received and processed. > > Does this happen for you if you use ata_piix? I have enabled the ATA drivers on my test system now, and I still don't see the issue. "hd*" for CDROM devices has been marked deprecated in udev since 2009 (!). Is it possible that you have the legacy udisksd running, and didn't disable CD-ROM polling? Martin