From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755260AbcKVJEy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Nov 2016 04:04:54 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:56499 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751952AbcKVJEw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Nov 2016 04:04:52 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation
Date: Tue, 22 Nov 2016 10:04:21 +0100
Message-ID: <4774803.kQO20ucMKM@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CACRpkdb1RdDCjT3ChiJdF8WZHp-Sb1un1tvSOh3uShZn2DaZ-Q@mail.gmail.com>
References: <20161116152047.3336967-1-arnd@arndb.de> <CACRpkdb1RdDCjT3ChiJdF8WZHp-Sb1un1tvSOh3uShZn2DaZ-Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:yxXrwc8WJMFOc/hJ7Zr57jEAJfSIOzf1wHkraUF1ocAR+qp05KF
 NomRZ1sCtITYatm1VoU4uvElWPAVuPaBy9VMKmNPcIDMr5osO2XOBXuPbRWRRl087/5Uzay
 9V49xchMCfiTOm7Rldgh4lS+xxvri6eDXRdhvEfObkMPW6JPFNZ99Ev9Dd9ge2FCQGt9m91
 sBwXXtFKOhEny5wTXOTIw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:UXrlDRnccug=:50nKSUZ3ONaiofCqMldbbn
 mUjMhwN9yCpbRxQLhNqbmvlOJmvHF+eOyU2R/JbInaIOaPe/BDKFwQf7/htKCB3NojJ6fWWGT
 tHw9yWh3KSVLPsvWmrkgHt3Ri6zAd0l5MUNl1rvt2+rJqhgZurumgvygRkE55fsFsJRZtHrWH
 /d/ApCmysb1qT7C2mkYTD3URWnkonoraChCER77UNSq4gYAOYgoi7qlZG2jqmtEJGSCllTh19
 AQy3pfBlqQPl17X7OGGRWx05x5m+xNALgAWBS2nmMh9UmpffNKNt1aLd2Mb/H7rvpcOl9M4Fb
 akW+T0vBQU2XMTIeusuI3MGMa1vy7D/0z7lPAWMh8SAWBjB/ttzVaI5Vp0NccCAZGSYnDE5t4
 fZme55BrkukOImg4Hs1PSZ9eUdFlxyXNQZPtjatriEmq6+HJ91PsXBXY+xGnkhHzUdkL1gMLM
 8koF3ZqJ34pjRNG68rZH1GHxxbtXGihYR9KSntImx3p3K4JSmrfit+l6D0JIv3jdU1i0en8N5
 DlZH584nIsbz9KXpBvzVRNAGjsW4h8DMHPNYaQxWpgvZOaGR+dTMsUKb6I8cvey6FpisqtEG4
 lbPjFL1b3rwxnawBf0A7AoJM0JJrSA9UhKtz8tQo2U/yzfnZr169mHNtV7skwIdiU7DJZ2BX4
 ++1L1jqd+ehzfJbPNG/aDs5z4fePYjzAqaQ8485E/UyrkQvct2sX05XVlWaj2g71eehIo/MdE
 o26LGleA/FtS4RMw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, November 22, 2016 9:47:20 AM CET Linus Walleij wrote:
> On Wed, Nov 16, 2016 at 4:20 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > This function clearly never worked and always returns true,
> > as pointed out by gcc-7:
> >
> > arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi':
> > arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]
> >
> > With the added braces, the condition actually makes sense.
> >
> > Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Will you apply it directly to ARM SoC or should I queue it and
> send it with a pull request?

I'd prefer you to queue and track it, thanks,

	Arnd