From: Faiyaz Mohammed <faiyazm@codeaurora.org>
To: Vlastimil Babka <vbabka@suse.cz>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>,
glittao@gmail.com, vinmenon@codeaurora.org
Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs
Date: Tue, 8 Jun 2021 23:43:34 +0530 [thread overview]
Message-ID: <47842d8d-2747-3d0f-8695-122dc23d90e6@codeaurora.org> (raw)
In-Reply-To: <78fc8848-bde8-769e-f8e9-6157d232a60f@suse.cz>
On 6/8/2021 11:05 PM, Vlastimil Babka wrote:
> On 6/8/21 7:11 PM, Faiyaz Mohammed wrote:
>>
>>
>> On 6/8/2021 5:20 PM, Andy Shevchenko wrote:
>>> On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
>>>>
>>>> alloc_calls and free_calls implementation in sysfs have two issues,
>>>> one is PAGE_SIZE limitation of sysfs and other is it does not adhere
>>>> to "one value per file" rule.
>>>>
>>>> To overcome this issues, move the alloc_calls and free_calls
>>>> implementation to debugfs.
>>>>
>>>> Debugfs cache will be created if SLAB_STORE_USER flag is set.
>>>>
>>>> Rename the alloc_calls/free_calls to alloc_traces/free_traces,
>>>> to be inline with what it does.
>>>>
>>>> Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
>>>> ---
>>>
>>> It seems you missed the version bump along with changelog.
>>> Note, some maintainers (actually quite many I think) are using tools
>>> to fetch up the patches and two patches with the same version is a
>>> problem. Hence I do not consider it a nit-pick.
>>>
>> Hmmm, I think to avoid same version problem I have to push same patch
>> with new version number and thank you for your patience.
>
> I *think* Andrew wouldn't have this issue, so maybe resend only if he says it's
> needed.
Sure, I will send if he ask.
> On the other hand I did have troubles to apply the last version locally, patch
> (tool) complained of patch (file) being malformed at the end. Did you add or
> delete lines from it after generating the patch? I had to use the recountdiff
Yes, I added one line manually, I think that causes the issue.
> tool to fix this. If you're going to resend, please make sure it's without the
> same issue.
>
Okay
>> Thanks and regards,
>> Mohammed Faiyaz
>>
>
next prev parent reply other threads:[~2021-06-08 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:45 [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs Faiyaz Mohammed
2021-06-08 9:41 ` Vlastimil Babka
2021-06-08 11:50 ` Andy Shevchenko
2021-06-08 17:11 ` Faiyaz Mohammed
2021-06-08 17:35 ` Vlastimil Babka
2021-06-08 18:13 ` Faiyaz Mohammed [this message]
2021-06-10 8:56 ` Faiyaz Mohammed
2021-06-10 10:16 ` Andy Shevchenko
2021-06-10 10:18 ` Vlastimil Babka
-- strict thread matches above, loose matches on Subject: below --
2021-06-08 1:32 Faiyaz Mohammed
2021-06-08 7:28 ` kernel test robot
2021-06-08 7:35 ` Faiyaz Mohammed
2021-06-08 13:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47842d8d-2747-3d0f-8695-122dc23d90e6@codeaurora.org \
--to=faiyazm@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=cl@linux.com \
--cc=glittao@gmail.com \
--cc=greg@kroah.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).