From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C29FC43334 for ; Thu, 23 Jun 2022 12:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231759AbiFWMIr (ORCPT ); Thu, 23 Jun 2022 08:08:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbiFWMIp (ORCPT ); Thu, 23 Jun 2022 08:08:45 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF424B403; Thu, 23 Jun 2022 05:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1655986122; x=1687522122; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9/CCr0snWfftSFhkeAYUhF2+vCU0/VTKAyn0ef5b+1M=; b=RfLwjfKgpEQJskz0RHl1y/wsjOtM21oPgA41GOcm36Prlk0L+V6Lt+ae jxD/4pLS5An/DikbhT92gC1r0r3pZlHOir14EHNaWyaX6585ZZoI5+tc6 eam11olTQOYvdbXOq+Xu9iSL3RsSWyZDBJ+kxstTdCyOrw+3c+Rlzm/To ZgjU4ZAVxLK/nSgHoKbv9o1zeFfONkeabUw22LWSSeGD/ndYGt0jRpzJH A/D4nJ8F5GiI6828iI9n3umJFtbZnfGSguJB1xsMMAvpEiFXXVUjBsK9J kcObcbG9vysqfGvdILhrn9dnYrbAuw4H38YiOudt78jtrRD3Hw2FJTIUR A==; X-IronPort-AV: E=Sophos;i="5.92,216,1650924000"; d="scan'208";a="24631790" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 23 Jun 2022 14:08:39 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 23 Jun 2022 14:08:39 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 23 Jun 2022 14:08:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1655986119; x=1687522119; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9/CCr0snWfftSFhkeAYUhF2+vCU0/VTKAyn0ef5b+1M=; b=HqDs5ssF8L1EkiBFh2ujtpvauytr8wW9ynjPp2xOnD4EQm4zS6BPcHVl lxCOGE9jVnfEHBD/8sdZQllqvQTP/1hCMj4QZY6SY4Dsotw+F09xiTIbq kPGuT6sVq23fcovCydMWi8mwrwIkHuq0JdWTnYE+8HL1BZeE7m/EB/0Z2 jXy8EAKffPqzrkqqO6YcQzKY7pIfLm1sMMrgzEp3d8Y8kwIXrn9ZM9Ms+ zqG3kEyie1oOETmmWcRSdR2GYyqnkSUJwZUXPsUDFrdSKw9PLlNJufhlU z97RAyDul51fuxwcMhrOWtYtivSC6bw3XtK+NKpUAday6W/pIZCXrl64Z w==; X-IronPort-AV: E=Sophos;i="5.92,216,1650924000"; d="scan'208";a="24631789" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 23 Jun 2022 14:08:39 +0200 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id C37F4280056; Thu, 23 Jun 2022 14:08:38 +0200 (CEST) From: Alexander Stein To: Saravana Kannan , Tony Lindgren Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Joerg Roedel , Will Deacon , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Hideaki YOSHIFUJI , David Ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Date: Thu, 23 Jun 2022 14:08:38 +0200 Message-ID: <4799738.LvFx2qVVIh@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20220601070707.3946847-1-saravanak@google.com> <20220601070707.3946847-2-saravanak@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Dienstag, 21. Juni 2022, 09:28:43 CEST schrieb Tony Lindgren: > Hi, > > * Saravana Kannan [700101 02:00]: > > Now that fw_devlink=on by default and fw_devlink supports > > "power-domains" property, the execution will never get to the point > > where driver_deferred_probe_check_state() is called before the supplier > > has probed successfully or before deferred probe timeout has expired. > > > > So, delete the call and replace it with -ENODEV. > > Looks like this causes omaps to not boot in Linux next. With this > simple-pm-bus fails to probe initially as the power-domain is not > yet available. On platform_probe() genpd_get_from_provider() returns > -ENOENT. > > Seems like other stuff is potentially broken too, any ideas on > how to fix this? I think I'm hit by this as well, although I do not get a lockup. In my case I'm using arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts and probing of 38320000.blk-ctrl fails as the power-domain is not (yet) registed. See the (filtered) dmesg output: > [ 0.744245] PM: Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@0 [ 0.744756] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@2 [ 0.745012] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@3 [ 0.745268] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@4 [ 0.746121] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@7 [ 0.746400] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@8 [ 0.746665] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@9 [ 0.746927] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@a [ 0.748870] > imx8m-blk-ctrl 38320000.blk-ctrl: error -ENODEV: failed to attach bus power > domain [ 1.265279] PM: Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@5 [ 1.265861] PM: > Added domain provider from > /soc@0/bus@30000000/gpc@303a0000/pgc/power-domain@6 blk-ctrl@38320000 requires the power-domain 'pgc_vpu', which is power-domain@6 in pgc. Best regards, Alexander > > Signed-off-by: Saravana Kannan > > --- > > > > drivers/base/power/domain.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > > index 739e52cd4aba..3e86772d5fac 100644 > > --- a/drivers/base/power/domain.c > > +++ b/drivers/base/power/domain.c > > @@ -2730,7 +2730,7 @@ static int __genpd_dev_pm_attach(struct device *dev, > > struct device *base_dev,> > > mutex_unlock(&gpd_list_lock); > > dev_dbg(dev, "%s() failed to find PM domain: %ld\n", > > > > __func__, PTR_ERR(pd)); > > > > - return driver_deferred_probe_check_state(base_dev); > > + return -ENODEV; > > > > } > > > > dev_dbg(dev, "adding to PM domain %s\n", pd->name);