Re: [PATCH v3 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings

[Taniya Das <tdas@codeaurora.org>]

Hello Stephen,

Thanks for the review comments.

On 8/28/2018 2:44 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-08-03 05:21:13)
>> Add device tree bindings for Low Power Audio subsystem clock controller for
>> Qualcomm Technology Inc's SDM845 SoCs.
>>
>> Signed-off-by: Taniya Das <tdas@codeaurora.org>
>> ---
>>   .../devicetree/bindings/clock/qcom,gcc.txt         |  2 ++
>>   .../devicetree/bindings/clock/qcom,lpasscc.txt     | 33 ++++++++++++++++++++++
>>   include/dt-bindings/clock/qcom,gcc-sdm845.h        |  2 ++
>>   include/dt-bindings/clock/qcom,lpass-sdm845.h      | 16 +++++++++++
>>   4 files changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
>>   create mode 100644 include/dt-bindings/clock/qcom,lpass-sdm845.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.txt b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> index 664ea1f..e452abc 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> @@ -32,6 +32,8 @@ be part of GCC and hence the TSENS properties can also be
>>   part of the GCC/clock-controller node.
>>   For more details on the TSENS properties please refer
>>   Documentation/devicetree/bindings/thermal/qcom-tsens.txt
>> +- qcom,lpass-protected : Indicate GCC to be able to access the
>> +                       lpass gcc clock branches.
> 
> This doesn't parse well for me. Maybe something like:
> 
> 'Indicate that the LPASS clock branches within GCC are unusable due to
> firmware access control restrictions'?
> 

Sure, will update in the next series.

>>
>>   Example:
>>          clock-controller@900000 {
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
>> new file mode 100644
>> index 0000000..062e413
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
>> @@ -0,0 +1,33 @@
>> +Qualcomm LPASS Clock Controller Binding
>> +-----------------------------------------------
>> +
>> +Required properties :
>> +- compatible           : shall contain "qcom,sdm845-lpasscc"
>> +- #clock-cells         : from common clock binding, shall contain 1.
>> +- reg                  : shall contain base register address and size,
>> +                         in the order
>> +                       Index-0 maps to LPASS_CC register region
>> +                       Index-1 maps to LPASS_QDSP6SS register region
>> +- qcom,lpass-protected : Boolean property to indicate to GCC clock controller
>> +                        for the lpass GCC clocks.
> 
> Why is this here?
> 

Yes, I kept it to make sure it is marked in GCC clock driver too. May be 
should remove it.

>> +
>> +Optional properties :
>> +- reg-names    : register names of LPASS domain
>> +                "lpass_cc", "lpass_qdsp6ss".
>> +
>> +Example:
>> +
>> +The below node has to be defined in the cases where the LPASS peripheral loader
>> +would bring the subsystem out of reset.
>> +
>> +       lpasscc: clock-controller {
>> +               compatible = "qcom,sdm845-lpasscc";
>> +               reg = <0x17014000 0x1f004>, <0x17300000 0x200>;
>> +               reg-names = "lpass_cc", "lpass_qdsp6ss";
>> +               #clock-cells = <1>;
>> +       };
>> +
>> +       gcc: clock-controller@100000 {
>> +               compatible = "qcom,gcc-sdm845";
>> +               qcom,lpass-protected;
>> +       };

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--