From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yinbo Zhu <yinbo.zhu@nxp.com>, Alan Stern <stern@rowland.harvard.edu>
Cc: xiaobo.xie@nxp.com, jerry.huang@nxp.com, ran.wang_1@nxp.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ramneek Mehresh <ramneek.mehresh@freescale.com>,
Nikhil Badola <nikhil.badola@freescale.com>,
Suresh Gupta <suresh.gupta@freescale.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/6] usb: host: Stops USB controller init if PLL fails to lock
Date: Mon, 21 Jan 2019 11:16:52 +0300 [thread overview]
Message-ID: <47b5e88e-2886-d8ed-5700-fad31c58f9bd@cogentembedded.com> (raw)
In-Reply-To: <20190121031304.31161-3-yinbo.zhu@nxp.com>
Hello!
On 21.01.2019 6:13, Yinbo Zhu wrote:
> From: yinbo.zhu <yinbo.zhu@nxp.com>
>
> USB erratum-A006918 workaround tries to start internal PHY inside
> uboot (when PLL fails to lock). However, if the workaround also
> fails, then USB initialization is also stopped inside Linux.
> Erratum-A006918 workaround failure creates "fsl,erratum_a006918"
> node in device-tree. Presence of this node in device-tree is
> used to stop USB controller initialization in Linux
>
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
> ---
> drivers/usb/host/ehci-fsl.c | 5 +++++
> drivers/usb/host/fsl-mph-dr-of.c | 5 +++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index a28ec1e..6884130 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -224,6 +224,11 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
> portsc |= PORT_PTS_PTW;
> /* fall through */
> case FSL_USB2_PHY_UTMI:
> + if (pdata->has_fsl_erratum_a006918) {
> + pr_warn("fsl-ehci: USB PHY clock invalid\n");
> + return -EINVAL;
> + }
> +
> case FSL_USB2_PHY_UTMI_DUAL:
> /* PHY_CLK_VALID bit is de-featured from all controller
> * versions below 2.4 and is to be checked only for
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 677f9d5..7e07701 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -225,6 +225,11 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
> pdata->has_fsl_erratum_a005697 =
> of_property_read_bool(np, "fsl,usb_erratum-a005697");
>
> + if (of_get_property(np, "fsl,erratum_a006918", NULL))
of_property_read_bool() perhaps?
> + pdata->has_fsl_erratum_a006918 = 1;
> + else
> + pdata->has_fsl_erratum_a006918 = 0;
> +
> /*
> * Determine whether phy_clk_valid needs to be checked
> * by reading property in device tree
MBR, Sergei
next prev parent reply other threads:[~2019-01-21 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 3:12 [PATCH v1 1/6] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
2019-01-21 3:13 ` [PATCH v1 2/6] usb: phy: Workaround for USB erratum-A005728 Yinbo Zhu
2019-01-21 7:46 ` Greg Kroah-Hartman
2019-01-21 3:13 ` [PATCH v1 3/6] usb: host: Stops USB controller init if PLL fails to lock Yinbo Zhu
2019-01-21 7:46 ` Greg Kroah-Hartman
2019-01-21 8:16 ` Sergei Shtylyov [this message]
2019-01-21 10:08 ` Yinbo Zhu
2019-01-21 3:13 ` [PATCH v1 4/6] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918 Yinbo Zhu
2019-01-21 3:13 ` [PATCH v1 5/6] usb: linux/fsl_device: Add platform member has_fsl_erratum_14 Yinbo Zhu
2019-01-21 3:13 ` [PATCH v1 6/6] usb :fsl: Change string format for errata property Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b5e88e-2886-d8ed-5700-fad31c58f9bd@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerry.huang@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikhil.badola@freescale.com \
--cc=ramneek.mehresh@freescale.com \
--cc=ran.wang_1@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=suresh.gupta@freescale.com \
--cc=xiaobo.xie@nxp.com \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).