From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99302C43603 for ; Wed, 18 Dec 2019 04:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71A3120715 for ; Wed, 18 Dec 2019 04:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfLREFM (ORCPT ); Tue, 17 Dec 2019 23:05:12 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:46233 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbfLREFL (ORCPT ); Tue, 17 Dec 2019 23:05:11 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 47d1cj6QD8z9sS3; Wed, 18 Dec 2019 15:05:09 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 099bc4812f09155da77eeb960a983470249c9ce1 In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/irq: fix stack overflow verification Message-Id: <47d1cj6QD8z9sS3@ozlabs.org> Date: Wed, 18 Dec 2019 15:05:09 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-12-09 at 06:19:08 UTC, Christophe Leroy wrote: > Before commit 0366a1c70b89 ("powerpc/irq: Run softirqs off the top of > the irq stack"), check_stack_overflow() was called by do_IRQ(), before > switching to the irq stack. > In that commit, do_IRQ() was renamed __do_irq(), and is now executing > on the irq stack, so check_stack_overflow() has just become almost > useless. > > Move check_stack_overflow() call in do_IRQ() to do the check while > still on the current stack. > > Fixes: 0366a1c70b89 ("powerpc/irq: Run softirqs off the top of the irq stack") > Cc: stable@vger.kernel.org > Signed-off-by: Christophe Leroy Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/099bc4812f09155da77eeb960a983470249c9ce1 cheers