From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7931FCA9EAD for ; Sat, 19 Oct 2019 20:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB5F22473 for ; Sat, 19 Oct 2019 20:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbfJSUom convert rfc822-to-8bit (ORCPT ); Sat, 19 Oct 2019 16:44:42 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49748 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbfJSUol (ORCPT ); Sat, 19 Oct 2019 16:44:41 -0400 Received: from turkeyburger.collabora.co.uk (turkeyburger.collabora.co.uk [46.235.227.230]) by bhuna.collabora.co.uk (Postfix) with ESMTP id C2434263BB2; Sat, 19 Oct 2019 21:44:38 +0100 (BST) Content-Type: text/plain; charset="utf-8" In-Reply-To: <5DA9EE2F.4030603@zoho.com> From: "Ezequiel Garcia" X-Forward: 81.67.116.94 Date: Sat, 19 Oct 2019 21:44:38 +0100 Cc: "Ulf Hansson" , "Paul Cercueil" , linux-mips@vger.kernel.org, "Linux Kernel Mailing List" , =?utf-8?q?linux-mmc=40vger=2Ekernel=2Eorg?= , "DTML" , "Rob Herring" , "Paul Burton" , "Mark Rutland" , syq@debian.org, "Linus Walleij" , armijn@tjaldur.nl, "Thomas Gleixner" , "YueHaibing" , "Mathieu Malaterre" To: "Zhou Yanjie" MIME-Version: 1.0 Message-ID: <47f6-5dab7580-33-5680128@176712317> Subject: =?utf-8?q?Re=3A?==?utf-8?q?_=5BPATCH?==?utf-8?q?_6=2F6?==?utf-8?q?_v2=5D?= =?utf-8?q?_MMC=3A?==?utf-8?q?_JZ4740=3A?= Add support for =?utf-8?q?LPM=2E?= User-Agent: SOGoMail 4.0.7 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, October 18, 2019 13:54 -03, Zhou Yanjie wrote: > > > > > I also have a general question. Should we perhaps rename the driver > > from jz4740_mmc.c to ingenic.c (and the file for the DT bindings, the > > Kconfig, etc), as that seems like a more appropriate name? No? > > I am very much in favor of this proposal. Now jz4740_mmc.c is not only used > for the JZ4740 processor, it is also used for JZ4725, JZ4760, JZ4770, JZ4780 > and X1000, and now Ingenic's processor is no longer named after JZ47xx, > it is divided into three product lines: M, T, and X. It is easy to cause > some > misunderstandings by using jz4740_mmc.c. At the same time, I think that > some register names also need to be adjusted. For example, the STLPPL > register name has only appeared in JZ4730 and JZ4740, and this register > in all subsequent processors is called CTRL. This time I was confused by > the STLPPL when I added drivers for the JZ4760's and X1000's LPM. > I am very much against renamings, for several reasons. As Paul already mentioned, it's pointless and just adds noise to the git-log, making history harder to recover. Driver file names don't really have to reflect the device exactly. For the compatibility list, it's far easier to just git-grep for compatible strings, or git-grep Documentation and/or Kconfig. Renaming macros and register names, is equally pointless and equally git-history invasive. Simply adding some documentation is enough. Thanks, Ezequiel