From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247AbcEaNSN (ORCPT ); Tue, 31 May 2016 09:18:13 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:58236 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878AbcEaNSM (ORCPT ); Tue, 31 May 2016 09:18:12 -0400 From: Arnd Bergmann To: Valentin Rothberg Cc: davem@davemloft.net, LKML , Andreas Ziegler Subject: Re: fou: dead build rule for fou6.o Date: Tue, 31 May 2016 15:18:34 +0200 Message-ID: <4806183.jXJkFW1R6y@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:k9MKu/9tp53LRbvJMKFrb64BBaUvo5bChS5eLbaIah2BMXd9MuR g4M2oP6ODa82hB1mgkznVMX6dWLJzfxgqBMR35GL+r6/WA0UE5BBn9uykR8YHQUeyqrogyF yr4fzf+eDQrgrWBusnNKWWEV1E6OAaRZHvxnnsXnIojbE6UTGgYIeLGYb8PawKPqPDvQafP ne9iIBaYtmiKCdrZiVQOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:nldWxeAztFw=:YycIwGpRXF6X10Zju+1Mfq i08T8sfUjTFIS3Ifl9LpIXJw7bAqcdsTJRCYzbrzQcfAXu6IhfBYQv2pUGeXAhzdT8CcpipmK lR0pfig58BqckWxX/ynK8iZsrJtGp7t3O0culcqjCX+d10BQP+sv1Bnl7T3IBs/MvfufU9StP ntN6P5DRDivJzZ8MlZzpeLswe/DAfTwTxUCxNf3NIgASUw85RR31V62wjYn6n9bbSew+WVpa6 3LaZrUY0bbMkmUiBpI8w7/NiQR7f0Pm3tufprIAPdEfiBW1TOPVe/JVbBL6akfra1iZkKDMv3 MeNomiPAP8m6nWTXjAS4Wj/b206EQI8avju9FwJZdeLkQvfRqc0zt+ALeUBUnMimWsTOIkl0s b0e7TWhVwT7EJa8DFk9FTht3RSlStMVCD4OgYW8oEoAiEqFLjnnIdftqfkinW5cz6A5avF74l 3iU5Mxab1dd89OEsILyjPB1HuQKkdKX1Ng9z8mxZCu0bWT28UKAjB0TxNxidEyFo2MMjMHvUx FI2FdVXn9+wYyAWlRhj0nZ6Tsco2Eo0dwSzPAhwr9ahaH0ZndhA9A/us9NMZpcdWlc73NY564 VlAenY7RN3SBISolLC0kAowRFYfz35V0McmbgUbbTF7LpW4+k1cCpbRm/YyGoAMP9gsy891I4 +Xp2GcyhgtyK+krJqT2b0O3bc1fvaKexVPFFsH0cgGTBMo2RqTtDeokN64n3KjP4SP6lMoZPa I+GTAZe+yQlItzg3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 31, 2016 8:25:40 AM CEST Valentin Rothberg wrote: > Hi Arnd, > > your commit fabb13db448e ("fou: add Kconfig options for IPv6 support") > has shown up in today's linux-next. ./scripts/checkkconfigsymbols.py > warned because of the following statement in net/ipv6/Makefile: > > +obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o > > The referenced Kconfig option does not exist, but I assume the right > option is 'IPV6_FOU_TUNNEL'? In case yes, the modified #if block in > the commit could be removed (redundant check). I found another mistake that was hidden by the one you found. The option controlling the file is IPV6_TUNNEL, not INET6_TUNNEL. I'm currently testing with the patch below to address both bugs. Arnd diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig index 994608263260..2343e4f2e0bf 100644 --- a/net/ipv6/Kconfig +++ b/net/ipv6/Kconfig @@ -239,7 +239,7 @@ config IPV6_FOU config IPV6_FOU_TUNNEL tristate default NET_FOU_IP_TUNNELS && IPV6_FOU - select INET6_TUNNEL + select IPV6_TUNNEL config IPV6_MULTIPLE_TABLES bool "IPv6: Multiple Routing Tables" diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile index d42ca3d1197f..6d8ea099213e 100644 --- a/net/ipv6/Makefile +++ b/net/ipv6/Makefile @@ -42,7 +42,7 @@ obj-$(CONFIG_IPV6_VTI) += ip6_vti.o obj-$(CONFIG_IPV6_SIT) += sit.o obj-$(CONFIG_IPV6_TUNNEL) += ip6_tunnel.o obj-$(CONFIG_IPV6_GRE) += ip6_gre.o -obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o +obj-$(CONFIG_IPV6_FOU) += fou6.o obj-y += addrconf_core.o exthdrs_core.o ip6_checksum.o ip6_icmp.o obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6-offload)