linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@gmail.com>
To: gcoady@gmail.com
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: 2.4: e100 accounting bust for multiple adapters
Date: Fri, 13 Jan 2006 23:50:38 -0800	[thread overview]
Message-ID: <4807377b0601132350y41c47d3bpb46b7b9af3690038@mail.gmail.com> (raw)
In-Reply-To: <53pgs11trhj0f6ik29hk41n4p5fegbft55@4ax.com>

On 1/13/06, Grant Coady <gcoady@gmail.com> wrote:
> On Wed, 11 Jan 2006 20:59:50 -0800, Jesse Brandeburg <jesse.brandeburg@gmail.com> wrote:
>
> >> Anyway the solution is simple: modular e100 is borked on 2.4,
> >> compiled in is okay.
> >
> >modular e100 2.X is borked, right? if you have a moment could you try
> >the 3.X e100 driver from sourceforge?
> >(http://prdownloads.sf.net/e1000) it should work fine on 2.4 and I
> >haven't heard any reports of icky stats.
>
> Hi Jesse,
>
> Couple of compile warnings:
> grant@deltree:~/e100-3.5.10/src$ make clean; make CFLAGS_EXTRA=-DE100_NO_NAPI
> rm -rf e100.o e100.o e100.o e100.o e100.o e100.7.gz .*cmd .tmp_versions
> gcc -DLINUX -D__KERNEL__ -DMODULE -O2 -pipe -Wall -I/lib/modules/2.4.32-hf32.1x/build/include -I. -DMODVERSIONS -DEXPORT_SYMTAB -include /lib/modules/2.4.32-hf32.1x/build/include/linux/modversions.h -DE100_NO_NAPI   -c -o e100.o e100.c
> In file included from /lib/modules/2.4.32-hf32.1x/build/include/linux/spinlock.h:6,
>                  from /lib/modules/2.4.32-hf32.1x/build/include/linux/module.h:12,
>                  from e100.c:138:
> /lib/modules/2.4.32-hf32.1x/build/include/asm/system.h: In function `__set_64bit_var':
> /lib/modules/2.4.32-hf32.1x/build/include/asm/system.h:190: warning: dereferencing type-punned pointer will break strict-aliasing rules
> /lib/modules/2.4.32-hf32.1x/build/include/asm/system.h:190: warning: dereferencing type-punned pointer will break strict-aliasing rules
>

I'm not sure but I don't think those warnings are from something e100
can control.

> **************************************************
> ** e100.o built for 2.4.32-hf32.1x
> ** SMP               Disabled
> **************************************************
>
> I have e100-3.5.10 up now and the stats now look okay.  Is this
> driver update headed for 2.4 kernel inclusion?

Most people running 2.4 seem to be okay with the old driver.  We
haven't maintained it for a long time, and have moved all of our
efforts to the more maintainable (rewritten) 3.X driver.  Basically
we've taken the position that 2.4 is legacy and if it ain't broke
don't fix it.

well, you've found something that broke, but maybe someone on list
here can help with a fix, but to answer your question its unlikely
that we'll attempt to rev the 2.4 driver unless something very serious
is brought up.

I'm hoping you can get along with the 3.X driver, and I'll be glad to
look into any issues that you come up with for that driver.

Jesse

  reply	other threads:[~2006-01-14  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-10  3:07 2.4: e100 accounting bust for multiple adapters Grant Coady
2006-01-11  0:24 ` Jesse Brandeburg
2006-01-11  1:35   ` Grant Coady
2006-01-12  4:59     ` Jesse Brandeburg
2006-01-14  2:55       ` Grant Coady
2006-01-14  7:50         ` Jesse Brandeburg [this message]
2006-01-14  8:24           ` Grant Coady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4807377b0601132350y41c47d3bpb46b7b9af3690038@mail.gmail.com \
    --to=jesse.brandeburg@gmail.com \
    --cc=gcoady@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).