From: <Tudor.Ambarus@microchip.com>
To: <potin.lai.pt@gmail.com>, <pratyush@kernel.org>,
<michael@walle.cc>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<vigneshr@ti.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<patrick@stwcx.xyz>, <potin.lai@quantatw.com>
Subject: Re: [RESEND PATCH v4 1/1] mtd: spi-nor: winbond: Add support for w25q01jvq
Date: Mon, 21 Nov 2022 13:50:50 +0000 [thread overview]
Message-ID: <4817515e-2833-6d39-03c3-30470344ac3a@microchip.com> (raw)
In-Reply-To: <20221111060530.2201084-1-potin.lai.pt@gmail.com>
On 11/11/22 08:05, Potin Lai wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Potin Lai <potin.lai@quantatw.com>
>
> Add support for winbond w25q01jvq chip
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> Reviewed-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> ---
> LINK: [v3] https://lore.kernel.org/all/20220222085148.21594-1-potin.lai@quantatw.com/
> LINK: [v2] https://lore.kernel.org/all/20220222064227.16724-1-potin.lai@quantatw.com/
> LINK: [v1] https://lore.kernel.org/all/20211224104522.24615-1-potin.lai@quantatw.com/
>
> Changes v3 --> v4:
> - fix correct chip name "w25q01jvq"
>
> root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
> ef4021
> root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
> winbond
> root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
> w25q01jvq
> root@bletchley:~# md5sum /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> a7b9dbf76e99a33db99e557b6676588a /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> root@bletchley:~# hexdump -C /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff |SFDP............|
> 00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff |................|
> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
> *
> 00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |. .....?D..k.;B.|
> 00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52 |..........@.. .R|
> 000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33 |....6........cv3|
> 000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5 |zuzu...\..M..p..|
> 000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
> 000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
> 000000d8
>
> Changes v2 --> v3:
> - move spi-nor flash information to comment area
>
> Changes v1 --> v2:
> - rework patch to work with new flags
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..e60ad92c0ace 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,8 @@ static const struct flash_info winbond_nor_parts[] = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jvq", INFO(0xef4021, 0, 64 * 1024, 2048)
> + PARSE_SFDP },
> };
>
Thanks all for sending and reviewing this patch. As this entry
uses just the PARSE_SFDP flag, without any specific flash/vendor
implementations, we could instead don't define an entry at all
and use the spi-nor-generic functionality introduced by Michael
at:
https://lore.kernel.org/linux-mtd/166903807811.85501.6803386075881922742.b4-ty@microchip.com/T/#t
I've applied Michael's patch set, please try the latest spi-nor/next
branch. We won't be adding new flash entries if the support for them
is solely based on SFDP, and will instead use the generic spi-nor-generic
driver introduced by Michael.
--
Cheers,
ta
prev parent reply other threads:[~2022-11-21 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 6:05 [RESEND PATCH v4 1/1] mtd: spi-nor: winbond: Add support for w25q01jvq Potin Lai
2022-11-11 6:20 ` Potin Lai
2022-11-20 15:15 ` Pratyush Yadav
2022-11-21 13:50 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4817515e-2833-6d39-03c3-30470344ac3a@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).